Conversation
b49b2a3 to
10550d0
Compare
There was a problem hiding this comment.
I've come around to this. Turns out it was 12AM (or whatever) and I wasn't thinking about the benefits of lowering the barrier to entry for adding more integration tests, so I'm sorry about that.
If you don't mind, I've got a few housekeeping requests:
- Rename it to
init-board-manifest.js- We may want to add other scripts to the fixtures
.jsextension ensures the linter will pick it up
- Put
init-board-manifest.jsinfixtures/binand wire it up infixtures/package.json{"bin": {"init-board-manifest": "bin/init-board-manifest.js"}}- That way,
yarn run init-board-manifestfrom the top level will be a thing
Then, to address the stuff I brought up in #64, can we more explicitly print out (a prompt would be amazing, but an interactive CLI is a much bigger project) what each setting was for each file? Something like:
please verify the following layer settings are correct
arduino-uno.cmp
> file type: gerber
> layer type: top copper
Looks like the current script relies on stdout piping, so that stuff could be fine to send to stderr via console.warn or something
|
Oops, closed automatically when I deleted |
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
=========================================
Coverage ? 88.57%
=========================================
Files ? 55
Lines ? 2180
Branches ? 0
=========================================
Hits ? 1931
Misses ? 249
Partials ? 0Continue to review full report at Codecov.
|
No description provided.