fix: prevent potential error by adding null check for tool.trace#432
Open
AyushKanani07 wants to merge 1 commit intotracespace:masterfrom
Open
fix: prevent potential error by adding null check for tool.trace#432AyushKanani07 wants to merge 1 commit intotracespace:masterfrom
AyushKanani07 wants to merge 1 commit intotracespace:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ErrorGerber.zip
While converting a Gerber ZIP file to SVG using the PCB Stackup library, I encountered a TypeError in the plotter.js file within the gerber-plotter package. This issue causes the Node.js server to crash, making it impossible to proceed with the conversion.
Error Details
The error occurs when running the following code:
When calling pcbStackup(layers), the Gerber Plotter package throws a TypeError due to tool.trace being undefined.
Error:
if (!this._region && tool.trace.length === 1) {
^
TypeError: Cannot read properties of null (reading 'trace')
The error originates from plotter.js, where the code attempts to access .length on tool.trace, which is null or undefined.
Since the error is unhandled, it crashes the entire Node.js server instead of failing gracefully.
Root Cause
Solution