Disable autoupload by default in PIO builds#3545
Open
CapnBry wants to merge 1 commit intoExpressLRS:masterfrom
Open
Disable autoupload by default in PIO builds#3545CapnBry wants to merge 1 commit intoExpressLRS:masterfrom
CapnBry wants to merge 1 commit intoExpressLRS:masterfrom
Conversation
CapnBry
changed the title
pkendall64
approved these changes
Feb 28, 2026
Collaborator
|
Maybe we could wait for a period of time at the prompt before continuing with the default? I think that would give us the best of both worlds. |
deadbytefpv
approved these changes
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disables the "auto upload" function of the config-append step of a build, now only performed if "autoupload" is set in the cache file.
Details
In #3449 we added the saving of the appended hardware config when you're doing a build, and it auto uploads that config if you do a PIO upload action without prompting. In practice now that we're using it, this is an opportunity to forget that you have to do a "clean" operation and upload the wrong hardware config by mistake 😞
The autoupload function can be re-enabled in the cache json, any value that evaluates to true in python works:
Any other options?
I'd love to have some easier way to toggle this, so I'm open to other ideas but I think it may be best to just make it a default-off option in the config for now. I didn't want to add a user_define for it because that seems wrong and forces a full rebuild if you change them.
Apologies to @mha1 for all the dead hardware needing reflashing!