X Tutup
The Wayback Machine - https://web.archive.org/web/20210823223732/https://github.com/RustPython/RustPython/issues/2837
Skip to content

/ RustPython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collections.deque doesn't have a __bool__ method. #2837

Open
Tracked in #2812
DimitrisJim opened this issue Aug 10, 2021 · 3 comments
Open
Tracked in #2812

collections.deque doesn't have a __bool__ method. #2837

DimitrisJim opened this issue Aug 10, 2021 · 3 comments
Assignees
@OhBonsai
Labels
good first issue

Comments

@DimitrisJim
Copy link
Member

@DimitrisJim DimitrisJim commented Aug 10, 2021 •
edited

Feature

CPython:

>>> from collections import deque
>>> deque().__bool__()
False

RustPython:

>>>>> from collections import deque
>>>>> deque().__bool__()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'deque' object has no attribute '__bool__'

bool for deques currently falls back to using __len__ when it should supply an implementation of __bool__.
@DimitrisJim DimitrisJim mentioned this issue Aug 10, 2021
Open
6 tasks
@OhBonsai
Copy link

@OhBonsai OhBonsai commented Aug 11, 2021

Hi, @DimitrisJim assign me plz~~
@DimitrisJim
Copy link
Member Author

@DimitrisJim DimitrisJim commented Aug 18, 2021

bump, any update on this @OhBonsai ?
@OhBonsai
Copy link

@OhBonsai OhBonsai commented Aug 20, 2021

bump, any update on this @OhBonsai ?

Hi, @DimitrisJim I will update in this weekend~
@OhBonsai OhBonsai mentioned this issue Aug 22, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OhBonsai OhBonsai

Labels
good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@DimitrisJim @OhBonsai
X Tutup