Conversation
filmor
force-pushed
the
ci
branch
6 times, most recently
from
805a7b3 to
8378487
Compare
Member
Author
|
Merging as is, will follow up on the remaining issues in a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes on Mono on macOS: The active fork at winehq should work on arm, but there are no binaries, yet. I don't intend to change that for the CI. Thus, we will only run .NET Core tests on macos arm for now. Alternatively, we use Homebrew, but we should extend it with some caching and set an env variable s.t. clr-loader can find it.
/edit: Still no binaries outside of homebrew, so we will go with that instead.