revert to C# 7.3

lostmsu · lostmsu · commit 02cd234a734e · 2020-05-13T14:03:51.000-07:00
diff --git a/src/embed_tests/Codecs.cs b/src/embed_tests/Codecs.cs
@@ -89,28 +89,32 @@ public void ExceptionEncoded() {
             PyObjectConversions.RegisterEncoder(new ValueErrorCodec());
             void CallMe() => throw new ValueErrorWrapper(TestExceptionMessage);
             var callMeAction = new Action(CallMe);
-            using var _ = Py.GIL();
-            using var scope = Py.CreateScope();
-            scope.Exec(@"
+            using (var _ = Py.GIL())
+            using (var scope = Py.CreateScope())
+            {
+                scope.Exec(@"
 def call(func):
   try:
     func()
   except ValueError as e:
     return str(e)
 ");
-            var callFunc = scope.Get("call");
-            string message = callFunc.Invoke(callMeAction.ToPython()).As<string>();
-            Assert.AreEqual(TestExceptionMessage, message);
+                var callFunc = scope.Get("call");
+                string message = callFunc.Invoke(callMeAction.ToPython()).As<string>();
+                Assert.AreEqual(TestExceptionMessage, message);
+            }
         }
 
         [Test]
         public void ExceptionDecoded() {
             PyObjectConversions.RegisterDecoder(new ValueErrorCodec());
-            using var _ = Py.GIL();
-            using var scope = Py.CreateScope();
-            var error = Assert.Throws<ValueErrorWrapper>(() => PythonEngine.Exec(
-                $"raise ValueError('{TestExceptionMessage}')"));
-            Assert.AreEqual(TestExceptionMessage, error.Message);
+            using (var _ = Py.GIL())
+            using (var scope = Py.CreateScope())
+            {
+                var error = Assert.Throws<ValueErrorWrapper>(()
+                    => PythonEngine.Exec($"raise ValueError('{TestExceptionMessage}')"));
+                Assert.AreEqual(TestExceptionMessage, error.Message);
+            }
         }
 
         class ValueErrorWrapper : Exception {
diff --git a/src/embed_tests/Python.EmbeddingTest.15.csproj b/src/embed_tests/Python.EmbeddingTest.15.csproj
@@ -23,7 +23,7 @@
     <SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\..\</SolutionDir>
     <PythonBuildDir Condition="'$(TargetFramework)'=='net40' AND '$(PythonBuildDir)' == ''">$(SolutionDir)\bin\</PythonBuildDir>
     <PublishDir Condition="'$(TargetFramework)'!='net40'">$(OutputPath)\$(TargetFramework)_publish</PublishDir>
-    <LangVersion>8.0</LangVersion>
+    <LangVersion>7.3</LangVersion>
     <ErrorReport>prompt</ErrorReport>
     <CustomDefineConstants Condition="'$(CustomDefineConstants)' == ''">$(PYTHONNET_DEFINE_CONSTANTS)</CustomDefineConstants>
     <BaseDefineConstants>XPLAT</BaseDefineConstants>
