feat: Sync file attachments to native by bitsandfoxes · Pull Request #5211 · getsentry/sentry-java

bitsandfoxes · 2026-03-18T12:59:05Z

📜 Description

Attachments added to the scope should get synced to sentry-native. I.e. a Unity games has

SentrySdk.ConfigureScope(scope => scope.AddAttachment("special-logfile.log");

and the game crashes, that attachment should be available in the resulting sentry event.

💡 Motivation and Context

Resolves #4758

💚 How did you test it?

Unit tests. Unity SDK will have e2e tests.

📝 Checklist

I added GH Issue ID & Linear ID
I added tests to verify the changes.
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
I updated the docs if needed.
I updated the wizard if needed.
Review from the native team if needed.
No breaking change or entry added to the changelog.
No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

This needs to be used and implemented in the hybrid SDKs.
Adding support to sync bytes as attachments.

github-actions · 2026-03-18T12:59:32Z

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

New Features ✨

Sync file attachments to native by bitsandfoxes in #5211

_{🤖 This preview updates automatically when you update the PR.}

github-actions · 2026-03-18T12:59:42Z

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 46718e3

sentry-android-ndk/src/main/java/io/sentry/android/ndk/NdkScopeObserver.java

…try/sentry-java into feat/sync-file-attachment

sentry · 2026-03-20T08:24:05Z

Sentry Build Distribution

App Name	App ID	Version	Configuration	Install Page
SDK Size	io.sentry.tests.size	8.37.1 (1)	release	Install Build

romtsn · 2026-03-20T11:20:35Z

sentry-android-ndk/src/main/java/io/sentry/android/ndk/NdkScopeObserver.java

+      return;
+    }
+
+    final byte[] bytes = attachment.getBytes();


there's also attachment.getByteProvider() which lazily evaluates and retrieves the bytes -- not sure if you want to support that from the gaming SDKs, but we use it when getting the bytes is heavy for the main thread, so it gets offloaded to the envelope serialization time on a bg thread, e.g.

sentry-java/sentry-android-core/src/main/java/io/sentry/android/core/ScreenshotEventProcessor.java

Lines 144 to 145 in 55aaf9b

Attachment.fromByteProvider(

() -> ScreenshotUtils.compressBitmapToPng(finalScreenshot, options.getLogger()),

I think invoking the ByteProvider from inside the signal handler is going to be extremely risky. But I'll keep that in mind.

romtsn

LGTM!

CHANGELOG.md

github-actions · 2026-03-20T11:57:19Z

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	352.81 ms	421.24 ms	68.43 ms
Size	0 B	0 B	0 B

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`6405ec5`	310.88 ms	354.56 ms	43.69 ms
`d5a29b6`	298.62 ms	391.78 ms	93.16 ms
`f064536`	329.00 ms	395.62 ms	66.62 ms
`fcec2f2`	357.47 ms	447.32 ms	89.85 ms
`bbc35bb`	324.88 ms	425.73 ms	100.85 ms
`694d587`	312.37 ms	402.77 ms	90.41 ms
`b8bd880`	314.56 ms	336.50 ms	21.94 ms
`889ecea`	367.58 ms	437.52 ms	69.94 ms
`e2dce0b`	308.96 ms	360.10 ms	51.14 ms
`83884a0`	334.46 ms	400.92 ms	66.46 ms

App size

Revision	Plain	With Sentry	Diff
`6405ec5`	1.58 MiB	2.12 MiB	552.23 KiB
`d5a29b6`	1.58 MiB	2.12 MiB	549.37 KiB
`f064536`	1.58 MiB	2.20 MiB	633.90 KiB
`fcec2f2`	1.58 MiB	2.12 MiB	551.50 KiB
`bbc35bb`	1.58 MiB	2.12 MiB	553.01 KiB
`694d587`	1.58 MiB	2.19 MiB	620.06 KiB
`b8bd880`	1.58 MiB	2.29 MiB	722.92 KiB
`889ecea`	1.58 MiB	2.11 MiB	539.75 KiB
`e2dce0b`	0 B	0 B	0 B
`83884a0`	1.58 MiB	2.29 MiB	722.97 KiB

github-actions · 2026-03-27T13:23:26Z

CHANGELOG.md


 ### Features

+- Android: Attachments on the scope will now be synced to native ([#5211](https://github.com/getsentry/sentry-java/pull/5211))


🚫 The changelog entry seems to be part of an already released section ## 8.37.1.
Consider moving the entry to the ## Unreleased section, please.

observe and sync file attachments

a3da89d

bitsandfoxes requested review from adinauer, markushi and romtsn as code owners March 18, 2026 12:59

Format code

af0502c

sentry bot reviewed Mar 18, 2026

View reviewed changes

sentry-android-ndk/src/main/java/io/sentry/android/ndk/NdkScopeObserver.java Show resolved Hide resolved

bitsandfoxes added 2 commits March 18, 2026 14:26

Updated CHANGELOG.md

80f8875

Merge branch 'feat/sync-file-attachment' of https://github.com/getsen…

944e481

…try/sentry-java into feat/sync-file-attachment

bitsandfoxes mentioned this pull request Mar 18, 2026

feat: Scope sync attachments getsentry/sentry-dotnet#5038

Merged

bitsandfoxes marked this pull request as draft March 18, 2026 16:25

bitsandfoxes mentioned this pull request Mar 18, 2026

feat: Scope sync file attachments getsentry/sentry-unity#2593

Closed

bitsandfoxes added 2 commits March 19, 2026 11:51

also attach bytes

6278324

bumped native ndk to 0.13.3

170e77b

bitsandfoxes added 2 commits March 20, 2026 09:32

updated api

2e2d0ac

more api

3597462

romtsn reviewed Mar 20, 2026

View reviewed changes

romtsn approved these changes Mar 20, 2026

View reviewed changes

bitsandfoxes commented Mar 20, 2026

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Apply suggestion from @bitsandfoxes

273a9ea

bitsandfoxes marked this pull request as ready for review March 20, 2026 11:41

Merge branch 'main' into feat/sync-file-attachment

1ffacfc

bitsandfoxes mentioned this pull request Mar 27, 2026

feat: Sync attachments on Android, Windows, and Linux getsentry/sentry-unity#2609

Open

Merge branch 'main' into feat/sync-file-attachment

46718e3

github-actions bot reviewed Mar 27, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Sync file attachments to native#5211

feat: Sync file attachments to native#5211
bitsandfoxes wants to merge 11 commits intomainfrom
feat/sync-file-attachment

bitsandfoxes commented Mar 18, 2026

Uh oh!

github-actions bot commented Mar 18, 2026 •

edited

Loading

New Features ✨

Uh oh!

github-actions bot commented Mar 18, 2026 •

edited

Loading

Uh oh!

Uh oh!

sentry bot commented Mar 20, 2026 •

edited

Loading

Uh oh!

romtsn Mar 20, 2026

Uh oh!

bitsandfoxes Mar 20, 2026

Uh oh!

romtsn left a comment

Uh oh!

Uh oh!

github-actions bot commented Mar 20, 2026 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot Mar 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	Attachment.fromByteProvider(
	() -> ScreenshotUtils.compressBitmapToPng(finalScreenshot, options.getLogger()),


		### Features

		- Android: Attachments on the scope will now be synced to native ([#5211](https://github.com/getsentry/sentry-java/pull/5211))

Uh oh!

Conversation

bitsandfoxes commented Mar 18, 2026

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Semver Impact of This PR

New Features ✨

Uh oh!

github-actions bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

sentry bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Sentry Build Distribution

Uh oh!

romtsn Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

bitsandfoxes Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

romtsn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Mar 18, 2026 •

edited

Loading

github-actions bot commented Mar 18, 2026 •

edited

Loading

sentry bot commented Mar 20, 2026 •

edited

Loading

github-actions bot commented Mar 20, 2026 •

edited

Loading