fix Set iterator not reflecting mutations after creation#1691
Open
RealColdFry wants to merge 3 commits intoTypeScriptToLua:masterfrom
Open
fix Set iterator not reflecting mutations after creation#1691RealColdFry wants to merge 3 commits intoTypeScriptToLua:masterfrom
RealColdFry wants to merge 3 commits intoTypeScriptToLua:masterfrom
Conversation
…oLua#1671) Set.values(), keys(), and entries() eagerly captured firstKey at iterator creation time. If the Set was mutated (e.g. via delete) before the iterator was consumed, the iterator still saw the stale firstKey. Read firstKey lazily on the first next() call instead.
Perryvw
reviewed
Mar 22, 2026
| const nextKey = this.nextKey; | ||
| let key: T = this.firstKey!; | ||
| let key: T | undefined; | ||
| let started = false; |
Member
There was a problem hiding this comment.
why add another bool instead of simply checking if key is undefined?
Author
There was a problem hiding this comment.
key can also become undefined if the iterator is exhausted. if the iterator is then next'ed again, it will reset and get the first key
Author
|
also added tests and code for Map.ts as it had the same pattern |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1671
Set.values(), keys(), and entries() eagerly captured firstKey at iterator creation time. If the Set was mutated (e.g. via delete) before the iterator was consumed, the iterator still saw the stale firstKey. Read firstKey lazily on the first next() call instead.