Plumb method for ejecting brass; add ejecting shotgun casings at correct time#995
Open
Thanson16 wants to merge 1 commit intoyvt:masterfrom
Open
Plumb method for ejecting brass; add ejecting shotgun casings at correct time#995Thanson16 wants to merge 1 commit intoyvt:masterfrom
Thanson16 wants to merge 1 commit intoyvt:masterfrom
Conversation
Break out ejecting brass into a dedicated method. Trigger this method after every shot. Add in appropriate delay so that shotgun casings are ejected during the pump action rather than when the shot is fired.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Break out ejecting brass into a dedicated method. Trigger this method after
every shot. Add in appropriate delay so that shotgun casings are ejected
during the pump action rather than when the shot is fired.
I was a little uncertain what to do around the
ComputeAmbienceandSetSoundEnvironmentstuff - if myEjectedBrassmethod needs thoseparts, let me know.
Tested on Linux, both as a player and in spectator mode.
Closes #917 , related to #909