Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @wsmd – Recently I started making use of your MusicKit typings and noticed the TODO to "add types for Apple Music API Objects".
I maintain the Apple Music API typings, which aim to provide exactly what your TODO calls for.
You can see the typings in their current state here: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/apple-music-api/index.d.ts
I would love to improve those typings too (there are some gaps that I just haven't covered yet because I haven't had particular use cases, e.g. for Music Videos) – so any pull requests would be welcome.
I hope you find this useful!
Sincerely,
Noah