Changed to escaped double-quotes to fix browser-sync#161
Merged
wesbos merged 1 commit intowesbos:masterfrom Sep 7, 2017
joshua-scott:master
Merged
Changed to escaped double-quotes to fix browser-sync#161wesbos merged 1 commit intowesbos:masterfrom joshua-scott:master
wesbos merged 1 commit intowesbos:masterfrom
joshua-scott:master
Conversation
The 'files' argument was being passed to browser-sync inside single quotes. These aren't recognised when the script runs, so hot-reloading was only listening for changes on the html file. Switching to escaped double quotes fixes this.
Owner
|
What OS are you on? The reason this is escaped is bc windows users can't have single quotes |
Contributor
Author
Windows 10. To clarify: the repo currently uses single quotes. I'm changing them to double quotes so it works for us Windows users too :) |
Owner
|
ohhh haha - I totally mixed up repos. Thanks :) |
EmmDguez
pushed a commit
to EmmDguez/JavaScript30
that referenced
this pull request
Jun 10, 2018
Changed to escaped double-quotes to fix browser-sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'files' argument was being passed to browser-sync inside single quotes. These aren't recognised when the script runs, so hot-reloading was only listening for changes on the html file.
Switching to escaped double quotes fixes this.