fix: Prevent sending message on IME confirmation with Enter key#919
Open
morikoudayo wants to merge 1 commit intovoideditor:mainfrom
Open
fix: Prevent sending message on IME confirmation with Enter key#919morikoudayo wants to merge 1 commit intovoideditor:mainfrom
morikoudayo wants to merge 1 commit intovoideditor:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When typing in languages that require IME composition (e.g., Japanese) in a chat interface with an LLM, Enter needs to be pressed twice. However, the message is currently sent on the first Enter key press during composition.
To fix this, I prevented the default action when e.browserEvent.isComposing is true, ensuring that the message is not sent while IME composition is still in progress.