X Tutup
Skip to content

Print install and remove messages below transaction summary#572

Merged
Duncaen merged 11 commits intovoid-linux:masterfrom
Duncaen:install-msg
Jan 23, 2025
Merged

Print install and remove messages below transaction summary#572
Duncaen merged 11 commits intovoid-linux:masterfrom
Duncaen:install-msg

Conversation

@Duncaen
Copy link
Member

@Duncaen Duncaen commented Sep 17, 2023

Continuation of #421.

  1. -n does not print the messages at the moment, I don't think breaking the parseable output is a good idea.
  2. removed the callbacks for the message, since its a lot easier to just print and work with the messages from where the transaction is summarized.
  3. removed xbps_cb_messge since its pointless, we can just print the data directly.
  4. simplified the message formatting (removed the big = padding, I think it looks better without, but this is arguable).
[*] Updating repository `https://repo-de.voidlinux.org/current/x86_64-repodata' ...
[*] Updating repository `https://repo-de.voidlinux.org/current/debug/x86_64-repodata' ...
[*] Updating repository `https://repo-de.voidlinux.org/current/nonfree/x86_64-repodata' ...
[*] Updating repository `https://repo-de.voidlinux.org/current/multilib/x86_64-repodata' ...
[*] Updating repository `https://repo-de.voidlinux.org/current/multilib/nonfree/x86_64-repodata' ...

Name           Action    Version           New version            Download size
SDL_gfx        install   -                 2.0.26_2               42KB
OpenXcom       install   -                 1.0_5                  1622KB
GraphicsMagick install   -                 1.3.40_1               85KB

Size to download:             1750KB
Size required on disk:        5247KB
Space available on disk:       810GB

[*] OpenXcom install message:
OpenXcom requires a vanilla version of the original
UFO: Enemy Unknown/X-COM: UFO Defense (any edition).
See /usr/share/doc/openxcom/README.txt for details.


[*] GraphicsMagick install message:
 The libgraphicsmagick-devel package contains the GraphicsMagick PERL
 extension. To install this extension follow the instructions in:

   /usr/share/doc/GraphicsMagick/PerlMagick/README.txt


Do you want to continue? [Y/n]

@classabbyamp
Copy link
Member

classabbyamp commented Sep 17, 2023 •
edited
Loading

-n does not print the messages at the moment, I don't think breaking the parseable output is a good idea.

I like the idea of putting them on stderr, that should prevent breaking anything that doesn't 2>&1 as discussed on irc, a regular run can be done and no can be chosen if users want to see these messages, as dryrun is probably only used for update checking scripts

Chocimier
Chocimier approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@Chocimier Chocimier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-n is only mode that shows transaction without root, sometimes I use it for quick look how it would look like. Yet, can't see any good way to include messages there.

@Duncaen Duncaen merged commit bbbd792 into void-linux:master Jan 23, 2025
@classabbyamp classabbyamp mentioned this pull request Mar 2, 2025
Closed
@classabbyamp classabbyamp mentioned this pull request May 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Chocimier Chocimier Chocimier approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Duncaen @classabbyamp @Chocimier
X Tutup