Cache Metal pipeline/depth states for re-use in future pipeline compilations#498
Open
frenzibyte wants to merge 4 commits intoveldrid:masterfrom
Open
Cache Metal pipeline/depth states for re-use in future pipeline compilations#498frenzibyte wants to merge 4 commits intoveldrid:masterfrom
frenzibyte wants to merge 4 commits intoveldrid:masterfrom
Conversation
…uce encoder commands
…e encoder commands
…duce encoder commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
GraphicsPipelinein Veldrid translates to four states in Metal (MTLRenderPipelineState,MTLComputePipelineState,MTLDepthStencilState, andThreadsPerThreadgroup). Multiple pipelines may be compiled to change certain states while keeping others as-is, this aims to cache all four states to re-use them for all pipelines where feasible and ultimately to reduce redundant bind calls which will come in #499.I've let disposal remove the caches mainly because the underlying device resources in the pipeline states are likely to be disposed themselves, so it's pointless to keep the cache existing.