fix(helm): Remove validation check for helm chart name#7873
Merged
olblak merged 2 commits intoupdatecli:mainfrom Mar 10, 2026
Merged
fix(helm): Remove validation check for helm chart name#7873olblak merged 2 commits intoupdatecli:mainfrom
olblak merged 2 commits intoupdatecli:mainfrom
Conversation
Member
|
Thanks for the pull request. After a quick test, it seems to be working well. |
olblak
approved these changes
Mar 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the “chart name required” validation for Helm target configuration so charts located at the repository root can be used without forcing a name.
Changes:
- Dropped
spec.Namenon-empty validation inValidateTarget. - Updated
ValidateTargetunit test expectations to no longer require an error whennameis empty.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/plugins/resources/helm/validate.go | Removes name required validation logic in target validation. |
| pkg/plugins/resources/helm/validate_test.go | Adjusts tests to align with name no longer being mandatory. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #5953
Removed validation check for name.
As per my understanding, in:
updatecli/pkg/plugins/resources/helm/target.goThe filepath is constructed as:
If the Chart.yaml is at the root of the directory, there should be no issue, since both paths resolve to the same file.
Test
To test this pull request, you can run the following commands:
go test -v ./pkg/plugins/resources/helm -run TestValidateTargetgo test -v ./pkg/plugins/resources/helm