test(config): add failure-case tests for helm template functions#7816
Merged
olblak merged 1 commit intoupdatecli:mainfrom Feb 23, 2026
Merged
test(config): add failure-case tests for helm template functions#7816olblak merged 1 commit intoupdatecli:mainfrom
olblak merged 1 commit intoupdatecli:mainfrom
Conversation
Resolve the TODO in TestHelmFuncs to cover the error-swallowing paths
in toYAML, fromYAML, and fromYAMLArray.
- toYAML: add errMarshaler helper type whose MarshalYAML returns an
error, confirming the function swallows it and returns an empty string.
- fromYaml: add a syntactically invalid YAML input ("key: [unclosed")
and assert the error is embedded under map["Error"].
- fromYamlArray: same invalid input, asserting the error string is
returned as the sole element of the slice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the
//TODO write tests for failure casescomment infuncsHelm_test.go:28.Changes:
errMarshalertest helper — implementsyaml.Marshalerand returnsan error — to exercise the error-swallowing path in
toYAML(returns"")fromYamltest case with syntactically invalid YAML input,asserting the error is embedded under
map["Error"]fromYamlArraytest case with same invalid input, asserting theerror string is the sole element of the returned slice
Note: channels/funcs panic (not error) in the yaml library so
errMarshalervia the
MarshalYAMLinterface is the correct way to trigger a marshal error.Test plan
go test ./pkg/core/config/ -run TestHelmFuncs— all cases pass