chore: improve error messaging in resource execution#7691
Merged
olblak merged 3 commits intoupdatecli:mainfrom Feb 10, 2026
Merged
chore: improve error messaging in resource execution#7691olblak merged 3 commits intoupdatecli:mainfrom
olblak merged 3 commits intoupdatecli:mainfrom
Conversation
Signed-off-by: Olblak <me@olblak.com>
olblak
added
enhancement
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves how pipeline execution errors are presented to users by enhancing pipeline-level error output formatting and reducing redundant logging from individual resource runs.
Changes:
- Update the exported pipeline error (
ErrRunTargets) message to refer to pipeline execution. - Remove direct
logrus.Errorflogging fromSource.Run()on failure paths (relying on pipeline-level reporting instead). - Enhance pipeline error logs to include formatted/indented error details and a summary header when errors are present.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/core/pipeline/targets.go | Updates the shared exported error message used when the pipeline run encounters failures. |
| pkg/core/pipeline/source/main.go | Removes error logging on failure paths to avoid duplicate/noisy logs (pipeline handles reporting). |
| pkg/core/pipeline/main.go | Improves error display formatting during execution and adds a clearer end-of-run error summary section. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor improvement when displaying error message
Test
Test manually
Additional Information
Checklist
Tradeoff
Potential improvement