feat(core): rename pipeline commands by josill · Pull Request #7613 · updatecli/updatecli

josill · 2026-01-26T15:49:14Z

Description

This PR implements updatecli pipeline diff and updatecli pipeline apply as new subcommands, following the same pattern as manifest subcommands. The existing updatecli diff and updatecli apply commands remain functional for backward compatibility but are marked as deprecated with warning messages.

Changes

New Commands Added:
- updatecli pipeline diff - Shows changes (replaces updatecli diff)
- updatecli pipeline apply - Checks and applies changes (replaces updatecli apply)
Backward Compatibility:
- updatecli diff and updatecli apply still work but show deprecation warnings
- Both old and new command paths route to the same execution logic
- No breaking changes for existing workflows

Test

To test this pull request, you can run the following commands:

# Build the binary
make build

# Test new commands exist and work
./dist/updatecli_$(go env GOHOSTOS)_$(go env GOHOSTARCH)/updatecli pipeline --help
./dist/updatecli_$(go env GOHOSTOS)_$(go env GOHOSTARCH)/updatecli pipeline diff --help
./dist/updatecli_$(go env GOHOSTOS)_$(go env GOHOSTARCH)/updatecli pipeline apply --help

# Test deprecated commands show warnings but still work
./dist/updatecli_$(go env GOHOSTOS)_$(go env GOHOSTARCH)/updatecli diff --help | grep -i deprecated
./dist/updatecli_$(go env GOHOSTOS)_$(go env GOHOSTARCH)/updatecli apply --help | grep -i deprecated

# Run unit tests
go test ./cmd/...

Additional Information

Checklist

Code follows existing patterns and conventions
Backward compatibility maintained
Deprecation warnings added
E2E tests added for new commands
E2E tests updated for deprecated commands
Documentation updated (should be done in separate PR to website repository)

Tradeoff

Shared Variables: The new pipeline subcommands reuse the same package-level variables (applyCommit, applyPush, diffClean, etc.) as the deprecated commands. This means both commands share flag state, which is intentional for consistency but means flags set on one command affect the other. This matches the existing pattern used by compose commands which have separate variables.
Deprecation Period: The old commands are deprecated but not removed, allowing users time to migrate. The deprecation warnings inform users without breaking existing workflows.

Potential improvement

In the future, consider renaming manifest to policy as discussed in the issue thread, which would create a more consistent command structure:
- updatecli pipeline - for executing pipelines
- updatecli policy - for policy manipulation (currently manifest)

josill · 2026-01-26T15:54:32Z

Idk remember if I asked this already somewhere, but I hope it's ok that I am taking task from "Backlog" section of the roadmap. I would also be happy to take tasks from the "Todo" section.

olblak · 2026-01-26T19:33:13Z

Idk remember if I asked this already somewhere, but I hope it's ok that I am taking task from "Backlog" section of the roadmap. I would also be happy to take tasks from the "Todo" section.

That's great, everything in the backlog is something that would be useful, some are more difficult than others.
We try to never introduce breaking changes, but instead we use deprecation.

Copilot

Pull request overview

This PR implements new updatecli pipeline diff and updatecli pipeline apply commands to provide a more consistent command structure, while maintaining backward compatibility by deprecating the existing updatecli diff and updatecli apply commands. This addresses issue #1879 which requested better command naming consistency.

Changes:

Added new pipeline parent command with diff and apply subcommands following the same pattern as existing manifest and compose commands
Deprecated old diff and apply commands with warnings but maintained functionality for backward compatibility
Updated command routing in cmd/root.go to handle both old and new command paths
Added E2E tests for the new pipeline commands and updated tests for deprecated commands

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
cmd/pipeline.go	New parent command for pipeline-related operations
cmd/pipeline_diff.go	New implementation of `pipeline diff` subcommand
cmd/pipeline_apply.go	New implementation of `pipeline apply` subcommand
cmd/diff.go	Updated with deprecation warning for backward compatibility
cmd/apply.go	Updated with deprecation warning for backward compatibility
cmd/root.go	Updated command routing to support both new and deprecated command paths
e2e/venom.d/test_pipeline.yaml	New E2E test suite for pipeline commands
e2e/venom.d/test_deprecated.yaml	Updated test suite for deprecated commands
e2e/scripts/test_pipeline_diff.bash	Test script for new pipeline diff command
e2e/scripts/test_pipeline_apply.bash	Test script for new pipeline apply command
e2e/scripts/test_deprecated.bash	Updated test script for deprecated commands

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

e2e/venom.d/test_pipeline.yaml

cmd/diff.go

cmd/apply.go

e2e/scripts/test_pipeline_apply.bash

e2e/scripts/test_deprecated.bash

olblak · 2026-01-27T07:39:20Z

I think we could remove the test "e2e/scripts/test_pipeline_apply.bash" and "e2e/scripts/test_diff.bash"

The first one because it's very similar to the diff since we can't commit changes

The second one because updatecli diff and updatecli pipeline diff should be similar.

The e2e tests are expensive and slow to run because we also integrate with third api so I would try to avoid too many of them if we can

olblak · 2026-01-27T07:42:45Z

Looking at this, I realize that updatecli prepare should also be deprecated to updatecli pipeline prepare

Signed-off-by: Olblak <me@olblak.com>

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cmd/pipeline_prepare.go

e2e/scripts/test_deprecated.bash

cmd/prepare.go

Signed-off-by: Olblak <me@olblak.com>

olblak · 2026-01-29T08:06:40Z

@josill I hope it's fine to you, I added a few commits to fix the e2e tests. I think the pull request is ready to merge

olblak · 2026-01-29T08:07:29Z

I also took the opportunity to deprecate updatecli prepare in favor of updatecli pipeline prepare

josill · 2026-01-29T08:26:39Z

@josill I hope it's fine to you, I added a few commits to fix the e2e tests. I think the pull request is ready to merge

Yes, no worries. I didn't have time to do the CR yet.

josill and others added 3 commits January 26, 2026 17:26

init

fedc3ef

add e2e tests

1328f60

Merge branch 'main' into feat/pipeline-commands

c6a41e9

josill marked this pull request as ready for review January 26, 2026 15:52

olblak requested a review from Copilot January 26, 2026 19:31

olblak added ux core All things related to Updatecli core engine labels Jan 26, 2026

Merge branch 'main' into feat/pipeline-commands

279156f

Copilot started reviewing on behalf of olblak January 26, 2026 19:31 View session

olblak enabled auto-merge (squash) January 26, 2026 19:34

Copilot AI reviewed Jan 26, 2026

View reviewed changes

e2e/venom.d/test_pipeline.yaml Outdated Show resolved Hide resolved

cmd/diff.go Show resolved Hide resolved

cmd/apply.go Show resolved Hide resolved

e2e/scripts/test_pipeline_apply.bash Outdated Show resolved Hide resolved

e2e/scripts/test_deprecated.bash Outdated Show resolved Hide resolved

olblak changed the title ~~Feat/pipeline commands~~ feat: rename pipeline commands Jan 26, 2026

olblak and others added 3 commits January 28, 2026 21:28

Merge branch 'main' into feat/pipeline-commands

04d1ba1

chore: simplify e2e tests

a40a490

Signed-off-by: Olblak <me@olblak.com>

chore: deprecate 'updatecli prepare' for 'updatecli pipeline prepare'

63f731e

Signed-off-by: Olblak <me@olblak.com>

olblak requested a review from Copilot January 28, 2026 21:00

Copilot started reviewing on behalf of olblak January 28, 2026 21:00 View session

Copilot AI reviewed Jan 28, 2026

View reviewed changes

cmd/pipeline_prepare.go Outdated Show resolved Hide resolved

cmd/pipeline_prepare.go Outdated Show resolved Hide resolved

e2e/scripts/test_deprecated.bash Show resolved Hide resolved

cmd/prepare.go Show resolved Hide resolved

olblak and others added 3 commits January 28, 2026 22:08

fix: wrong varialbe use

9b22ed3

Signed-off-by: Olblak <me@olblak.com>

Merge branch 'main' into feat/pipeline-commands

a001dcf

fix: e2e script

d8de657

Signed-off-by: Olblak <me@olblak.com>

olblak merged commit f74e709 into updatecli:main Jan 29, 2026
5 checks passed

olblak mentioned this pull request Jan 29, 2026

fix(file): file target bug with searchpattern and matchpattern #7629

Merged

olblak mentioned this pull request Jan 29, 2026

fix: e2e tests related to updatecli pipeline deprecation #7636

Merged

olblak added the enhancement New feature or request label Feb 5, 2026

olblak changed the title ~~feat: rename pipeline commands~~ feat(core): rename pipeline commands Feb 5, 2026

Uh oh!

Conversation

josill commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Test

Additional Information

Checklist

Tradeoff

Potential improvement

Uh oh!

josill commented Jan 26, 2026

Uh oh!

olblak commented Jan 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

olblak commented Jan 27, 2026

Uh oh!

olblak commented Jan 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

olblak commented Jan 29, 2026

Uh oh!

olblak commented Jan 29, 2026

Uh oh!

josill commented Jan 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

josill commented Jan 26, 2026 •

edited

Loading