fix: remove lowercase 'l' from compiler flags pattern to fix -latest false positive#7485
Merged
olblak merged 4 commits intoupdatecli:mainfrom Jan 13, 2026
Merged
Conversation
Member
|
nice catch |
Contributor
Author
|
Im not sure if the e2e tests are failing because of my changes. They seem unrelated.. |
Member
Yes I recently broke the e2e tests but this PR #7507 should fix them |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2804
This PR fixes a false positive in the spelling check where
-latestwas incorrectly recognized asatest.Root Cause:
The compiler flags pattern in
.github/actions/spelling/patterns.txtincluded a lowercaselin the character class[DPWXYLlf]. When encountering-latest, the pattern would match-l, leavingatestto be flagged as a misspelling.Solution:
Removed the lowercase
lfrom the pattern, changing-[DPWXYLlf]to-[DPWXYLf]. This change:-latest-D,-P,-W,-X,-Y,-L,-f)Lremains for library path flags like-L/path/to/libFiles Changed:
.github/actions/spelling/patterns.txt(line 53)Test
To test this pull request, you can run the following commands:
Before the fix: -latest would match -l, leaving 'atest' as false positive
After the fix: -latest is not matched by the pattern, so 'latest' is checked as a whole word (valid)Verification:
-latestto verify the fixReference: