feat(replaceAll): add replaceAll method for converting different semver conventions#7480
Merged
olblak merged 2 commits intoupdatecli:mainfrom Jan 11, 2026
Merged
feat(replaceAll): add replaceAll method for converting different semver conventions#7480olblak merged 2 commits intoupdatecli:mainfrom
olblak merged 2 commits intoupdatecli:mainfrom
Conversation
olblak
approved these changes
Jan 11, 2026
Member
olblak
left a comment
There was a problem hiding this comment.
Thanks for the pull request including the tests
ErickdelaCruzCas
pushed a commit
to ErickdelaCruzCas/updatecli
that referenced
this pull request
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a
ReplaceAllfeature to the version filter functionality, allowing users to apply regex-based transformations to version strings before filtering. This is particularly useful for normalizing version formats (e.g., convertingcurl-8_15_0tocurl-8.15.0) before regex extraction and semantic version matching.Closes #5864
Test
To test this pull request, you can run the following commands:
Or run the full test suite:
Additional Information
ReplaceAllstruct withPatternandReplacementfields to the version filterapplyReplaceAll()method that applies regex replacements before filteringReplaceAllfunctionality intoREGEXVERSIONKIND,REGEXSEMVERVERSIONKIND, andREGEXTIMEVERSIONKINDfilter typesReplaceAllpatterns in theValidate()methodChecklist
go testTradeoff
The
ReplaceAlltransformation is applied before regex extraction, which means:ReplaceAllis configuredThe validation happens at filter initialization time, catching invalid regex patterns early rather than at runtime.