Fix: Add missing 'code' field to swatch attribute option tests#252
Open
prismaticoder wants to merge 1 commit intounopim:masterfrom
Open
Fix: Add missing 'code' field to swatch attribute option tests#252prismaticoder wants to merge 1 commit intounopim:masterfrom
prismaticoder wants to merge 1 commit intounopim:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Reference
N/A - Bug fix discovered during test execution
Description
While running tests, the swatch attribute option tests in
Catalog/AttributeTestconsistently fail due to missing requiredcodefield. Theattribute_optionstable has a non-nullablecodecolumn, and the tests were not providing this field when creating new options.Changes:
codefield to color swatch attribute option testcodefield to image swatch attribute option testHow To Test This?
Run the affected tests:
./vendor/bin/pest packages/Webkul/Admin/tests/Feature/Catalog/AttributeTest.php --filter="swatch_value for select"Documentation
Branch Selection
Pint
N/A - Test file changes only
Tailwind Reordering
N/A - No Tailwind changes