Add "default" empty implementation for Timer and SleepMs()#170
Open
p12tic wants to merge 1 commit intounittest-cpp:masterfrom
Open
Add "default" empty implementation for Timer and SleepMs()#170p12tic wants to merge 1 commit intounittest-cpp:masterfrom
p12tic wants to merge 1 commit intounittest-cpp:masterfrom
Conversation
p12tic
force-pushed
the
timer-add-default-impl
branch
from
f70aeb8 to
452a6c7
Compare
Author
|
Note: the CI failure is not limited to this PR and is likely a preexisting problem on the master branch. See e.g. https://travis-ci.org/unittest-cpp/unittest-cpp/builds/322087958 |
Member
|
@p12tic thanks for the PR. I've been away for a while but I will take a look soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, let me thank you for the great library that UnitTest++ is.
This PR upstreams some of the changes we have in a private fork of UnitTest++ at Unity Technologies.
A "default" implementation of
TimerandTimeHelpers::SleepMs()has been added which could be used on platforms that either don't support timers or simply are not implemented in UnitTest (which does happen on weird platforms that Unity supports). Additionally, the implementation classes have been renamed to unique names so that accidental ODR clashes are not possible and instead we get a link error. Otherwise, depending on compilation flags, silent stack corruption would result.