refactor: use timer for 1 time task with delay as more idiomatic

Kaushik Gopal · Kaushik Gopal · commit e1e6773beedc · 2015-05-12T15:49:30.000-07:00
diff --git a/app/src/main/java/com/morihacky/android/rxjava/TimingDemoFragment.java b/app/src/main/java/com/morihacky/android/rxjava/TimingDemoFragment.java
@@ -56,22 +56,24 @@ public View onCreateView(LayoutInflater inflater,
     public void Btn1_RunSingleTaskAfter2s() {
         _log(String.format("A1 [%s] --- BTN click", _getCurrentTimestamp()));
 
-        Observable.just(1).delay(2, TimeUnit.SECONDS).subscribe(new Observer<Integer>() {
-            @Override
-            public void onCompleted() {
-                _log(String.format("A1 [%s] XXX COMPLETE", _getCurrentTimestamp()));
-            }
-
-            @Override
-            public void onError(Throwable e) {
-                Timber.e(e, "something went wrong in TimingDemoFragment example");
-            }
-
-            @Override
-            public void onNext(Integer integer) {
-                _log(String.format("A1 [%s]     NEXT", _getCurrentTimestamp()));
-            }
-        });
+        Observable.timer(2, TimeUnit.SECONDS)//
+              //.just(1).delay(2, TimeUnit.SECONDS)//
+              .subscribe(new Observer<Long>() {
+                  @Override
+                  public void onCompleted() {
+                      _log(String.format("A1 [%s] XXX COMPLETE", _getCurrentTimestamp()));
+                  }
+
+                  @Override
+                  public void onError(Throwable e) {
+                      Timber.e(e, "something went wrong in TimingDemoFragment example");
+                  }
+
+                  @Override
+                  public void onNext(Long number) {
+                      _log(String.format("A1 [%s]     NEXT", _getCurrentTimestamp()));
+                  }
+              });
     }
 
     @OnClick(R.id.btn_demo_timing_2)
@@ -84,44 +86,48 @@ public void Btn2_RunTask_IntervalOf1s() {
 
         _log(String.format("B2 [%s] --- BTN click", _getCurrentTimestamp()));
 
-        _subscription1 = Observable.interval(1, TimeUnit.SECONDS).subscribe(new Observer<Long>() {
-            @Override
-            public void onCompleted() {
-                _log(String.format("B2 [%s] XXXX COMPLETE", _getCurrentTimestamp()));
-            }
-
-            @Override
-            public void onError(Throwable e) {
-                Timber.e(e, "something went wrong in TimingDemoFragment example");
-            }
-
-            @Override
-            public void onNext(Long number) {
-                _log(String.format("B2 [%s]     NEXT", _getCurrentTimestamp()));
-            }
-        });
+        _subscription1 = Observable//
+              .interval(1, TimeUnit.SECONDS)//
+              .subscribe(new Observer<Long>() {
+                  @Override
+                  public void onCompleted() {
+                      _log(String.format("B2 [%s] XXXX COMPLETE", _getCurrentTimestamp()));
+                  }
+
+                  @Override
+                  public void onError(Throwable e) {
+                      Timber.e(e, "something went wrong in TimingDemoFragment example");
+                  }
+
+                  @Override
+                  public void onNext(Long number) {
+                      _log(String.format("B2 [%s]     NEXT", _getCurrentTimestamp()));
+                  }
+              });
     }
 
     @OnClick(R.id.btn_demo_timing_4)
     public void Btn4_RunTask5Times_IntervalOf3s() {
         _log(String.format("D4 [%s] --- BTN click", _getCurrentTimestamp()));
 
-        Observable.interval(3, TimeUnit.SECONDS).take(5).subscribe(new Observer<Long>() {
-            @Override
-            public void onCompleted() {
-                _log(String.format("D4 [%s] XXX COMPLETE", _getCurrentTimestamp()));
-            }
-
-            @Override
-            public void onError(Throwable e) {
-                Timber.e(e, "something went wrong in TimingDemoFragment example");
-            }
-
-            @Override
-            public void onNext(Long number) {
-                _log(String.format("D4 [%s]     NEXT", _getCurrentTimestamp()));
-            }
-        });
+        Observable//
+              .interval(3, TimeUnit.SECONDS).take(5)//
+              .subscribe(new Observer<Long>() {
+                  @Override
+                  public void onCompleted() {
+                      _log(String.format("D4 [%s] XXX COMPLETE", _getCurrentTimestamp()));
+                  }
+
+                  @Override
+                  public void onError(Throwable e) {
+                      Timber.e(e, "something went wrong in TimingDemoFragment example");
+                  }
+
+                  @Override
+                  public void onNext(Long number) {
+                      _log(String.format("D4 [%s]     NEXT", _getCurrentTimestamp()));
+                  }
+              });
     }
 
     // -----------------------------------------------------------------------------------
