Allow environment variables to be added from a map#150
Merged
rnorth merged 1 commit intotestcontainers:masterfrom Jun 10, 2016
haines:with-env-map
Merged
Allow environment variables to be added from a map#150rnorth merged 1 commit intotestcontainers:masterfrom haines:with-env-map
rnorth merged 1 commit intotestcontainers:masterfrom
haines:with-env-map
Conversation
| return self(); | ||
| } | ||
|
|
||
| /** |
Member
There was a problem hiding this comment.
you can do it as default method on Container interface as well since it's just a shortcut :)
Contributor
Author
There was a problem hiding this comment.
I would have preferred to do that but unfortunately then the withEnv method would return Container rather than GenericContainer, which is annoying. I've raised #151 because I've run into this type-casting problem before.
rnorth
added a commit
that referenced
this pull request
Jul 3, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
withEnv(Map<String, String>)to theContainerinterface, so that a bunch of environment variables from another source can be added at once.