Fix absolute image URLs in events list#313
Merged
shushugah merged 1 commit intotechworkersco:developfrom Jul 20, 2025
Merged
Conversation
`events.yml` and `events.json` were doing a simple concatenation of `site.url` and `event.image`, which worked for relative URLs but broke absolute URLs. For example, `https://info.rosalux.de/image/event/3bod2?type=2` became `https://techworkersberlin.com/https://info.rosalux.de/image/event/3bod2?type=2`, which is wrong. This causes issues for anyone consuming this data, such as [this bug on techworkerscoalition.org][0]. This fixes that with [Jekyll's built-in `absolute_url` filter][1], which [doesn't change URLs that are already absolute][2]. [0]: techworkersco/twc-site#431 [1]: https://jekyllrb.com/docs/liquid/filters/#absolute-url [2]: https://github.com/jekyll/jekyll/blob/76982c73c0df37ac79781ec1ef9518e08263a158/lib/jekyll/filters/url_filters.rb#L62
✅ Deploy Preview for techworkersberlin ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
events.ymlandevents.jsonwere doing a simple concatenation ofsite.urlandevent.image, which worked for relative URLs but broke absolute URLs. For example,https://info.rosalux.de/image/event/3bod2?type=2becamehttps://techworkersberlin.com/https://info.rosalux.de/image/event/3bod2?type=2, which is wrong.This causes issues for anyone consuming this data, such as this bug on techworkerscoalition.org.
This fixes that with Jekyll's built-in
absolute_urlfilter, which doesn't change URLs that are already absolute.