Fix CHT boundary problem for flamelet computations#2283
Merged
Conversation
Co-authored-by: Evert Bunschoten <38651601+EvertBunschoten@users.noreply.github.com>
… feature_fix_cht
Cristopher-Morales
changed the title
bigfooted
changed the title
Contributor
|
To me it looks like a better solution compared to the previous one because it prevents going into the isothermal wall function unnecessarily. LGTM, but maybe @pcarruscag can have a second look? |
pcarruscag
approved these changes
May 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Continuation of previous pull request #2281
[CHT + flamelet was only working if there was an additional isothermal wall present.]
Related Work
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --allto format old commits.