Workaround for ASLR/tsan incompatibility#2242
Merged
pcarruscag merged 1 commit intodevelopfrom Mar 15, 2024
Merged
Conversation
Contributor
Author
|
The changes do fix #2241, thread sanitizer builds and tests execute without crashing. The workaround is only needed until a corresponding fix in the github runner is deployed, which will take around a week (actions/runner-images#9491 (comment)). We could merge this now and roll it back later. @pcarruscag |
pcarruscag
approved these changes
Mar 15, 2024
Member
pcarruscag
left a comment
There was a problem hiding this comment.
Cool thanks for the quick fix 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Explore a workaround along the lines of openvswitch/ovs@fa0dfa1 to fix #2241
Related Work
#2241
PR Checklist
pre-commit run --allto format old commits.