Fix CST parameterization method#2124
Merged
pcarruscag merged 11 commits intosu2code:developfrom Sep 23, 2023
Merged
Conversation
Update master
pcarruscag
changed the title
pcarruscag
reviewed
Sep 1, 2023
Member
pcarruscag
left a comment
pcarruscag
left a comment
There was a problem hiding this comment.
Thanks, add yourself to AUTHORS.md please, since you added it as a testcase, we can try to make a regression test.
Can you check if your config works with the mesh I'm suggesting below (it's in the TestCases repo)? Then you need to change parallel_regression.py (look for /deformation/ to find the other tests).
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
Author
|
@pcarruscag , |
pcarruscag
reviewed
Sep 2, 2023
pcarruscag
reviewed
Sep 2, 2023
Contributor
Author
|
Sorry, some was caused by my carelessness,. I've modified it. |
pcarruscag
reviewed
Sep 3, 2023
pcarruscag
reviewed
Sep 4, 2023
pcarruscag
reviewed
Sep 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Work
I add some code about CST to CSurfaceMovement.cpp and it can work well.
I add a test case named "cst" in TestCases/deformation. It contains test case for CST mesh deformation.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --allto format old commits.