Add Velocity volume output for compressible flow solvers#2077
Add Velocity volume output for compressible flow solvers#2077pcarruscag merged 12 commits intosu2code:developfrom
Conversation
Added Velocity output, since I am interested in that and adding it only in the config just gets ignored and no output happens
There was a problem hiding this comment.
Welcome to SU2. You need to add these variables to the "PRIMITIVE" group, there is a comment // Primitive variables.
Look also for SetVolumeOutputValue("PRESSURE" because for each variable you need to add it and then set its value.
Please make the same change in CNEMOCompOutput.cpp
And add yourself to AUTHORS.md
Added Velocity Volume Output
Added Velocity Output
|
Hi, thank you for the warm welcome. I added the changes and hope they are sufficient. |
MastermindScope
changed the title
pcarruscag
left a comment
pcarruscag
left a comment
There was a problem hiding this comment.
Thanks, you are still missing the part of the code that sets the output value, AddVolumeOutput only adds the name.
Look for SetVolumeOutputValue in the files you changed, should be very close.
|
I've added SetVolumeOutputValue now. Thank you for being patient and letting me make mistakes. |
|
Hi! Just out of curiosity, if you're interested in just the velocity and not the momentum, why not just divide the momentum vector by the density during postprocessing? |
EvertBunschoten
left a comment
EvertBunschoten
left a comment
There was a problem hiding this comment.
Make sure you retrieve the velocity from the Primitive vector stored in the CVariable classes, not the Solution vector.
There are several reasons why:
|
pcarruscag
changed the title
5 participants
Disclaimer
This is my first ever contribution to any GitHub project. Please give feedback on what I can Improve if I haven't done something that is expected of me.
Proposed Changes
Added Velocity output, since I am interested in that and adding it only in the config just gets ignored and no output happens
Related Work
PR Checklist