Fix writing of multiple inlet profiles when using MPI#1999
Merged
Fix writing of multiple inlet profiles when using MPI#1999
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
pcarruscag
approved these changes
Apr 4, 2023
Member
pcarruscag
left a comment
pcarruscag
left a comment
There was a problem hiding this comment.
Is this testable somehow? Maybe a filediff regression that produces the example file?
Contributor
Author
Yes, when @danielmayer has merged the PR where we can compare output files, we can compare an existing inlet.dat with the newly created example_inlet.dat. I'll put that on the to-do list (I'll create an issue). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
SU2 writes an inlet profile for you when none is present and
SPECIFIED_INLET_PROFILE= YES. When there are multiple inlets, and when using mpi, the routine fails because the total number of inlet profilesmaxProfileswas not the total number of inlet profiles but only the maximum number of inlet profiles encountered in a rank. Some other info was also not communicated like column names and column values. This fixes the issue.Related Work
Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.
Reported here:
https://www.cfd-online.com/Forums/su2/248779-inlet-profile-su2-fluid-mixture.html
And connected to PR #1786
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.