Unit tests for multiple backslashes in JSONPointer#640
Merged
stleary merged 3 commits intostleary:masterfrom Nov 2, 2021
Merged
Unit tests for multiple backslashes in JSONPointer#640stleary merged 3 commits intostleary:masterfrom
stleary merged 3 commits intostleary:masterfrom
Conversation
context: the backslash unit tests cannot be in the complete document as uriFragmentNotationRoot() will fail due to backslash handling
Owner
|
What problem does this code solve? Risks Changes to the API? Will this require a new release? Should the documentation be updated? Does it break the unit tests? Was any code refactored in this commit? Review status |
Owner
|
Starting 3-day comment window |
johnjaylward
approved these changes
Nov 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[#561]Queries involving keys containing four backslashes ("\\") failing.
Summary of Issue
jimblackler noticed that different behavior occurs between parsing a string to create JSONObject and querying a JSONObject using JSONPointer(). There is not special handling for JSONPoiner \s in querying as mentioned in the fix for #588 .
I do think the documentation needs to be updated from
to
Summary of Changes
Expected Behavior