X Tutup
Skip to content

fix double ctor in JSONWriter#417

Merged
stleary merged 1 commit intomasterfrom
fix-double-ctor
May 16, 2018
Merged

fix double ctor in JSONWriter#417
stleary merged 1 commit intomasterfrom
fix-double-ctor

Conversation

@stleary
Copy link
Copy Markdown
Owner

@stleary stleary commented May 3, 2018

This replaces #414 which had a coding standards error (tab instead of spaces). Also just noticed we don't have any coding standards published. Will update the Wiki.

@stleary
Copy link
Copy Markdown
Owner Author

stleary commented May 3, 2018

What problem does this code solve?
The Double ctor is deprecated, so changed to with the recommended replacement method. This appears to only be an OpenJDK issue, but no harm in maintaining compatibility. For more information, see:
https://bugs.openjdk.java.net/browse/JDK-8176335.
This code was originally submitted in #414 but that change used a tab char, which has been corrected.

Risks
Low

Changes to the API?
No

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No. Confirmed that the existing tests already provide coverage for the modified line.

Was any code refactored in this commit?
No

Review status
APPROVED (#414 approval transferred to this pull request) Starting 3 day comment window.

@stleary stleary merged commit 3c1535d into master May 16, 2018
@stleary stleary deleted the fix-double-ctor branch July 1, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

X Tutup