You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What problem does this code solve?
This is a change to the README documentation. Normally it would just be committed, but in this case a few days will be included for review, in case anyone has comments. The project diverges from the specs in that when parsing strings, control chars other than '\n', '\r', and binary 0 are allowed. The team believes that the benefit of following the spec exactly does not outweigh the potential cost of breaking existing applications.
Changes to the API?
No.
Will this require a new release?
This change will be rolled into the next release, which is expected in June 2016 timeframe.
Should the documentation be updated?
Yes, this is the doc change (README only).
Change to unit tests?
A new unit test is added, which documents the existing behavior. See stleary/JSON-Java-unit-test#50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Readme to note that the parser allows some invalid JSON text while the generator never should.