Make textKey (default "content") configurable in XML-JSON conversion#108
Closed
jnothman wants to merge 1 commit intostleary:masterfrom
Closed
Make textKey (default "content") configurable in XML-JSON conversion#108jnothman wants to merge 1 commit intostleary:masterfrom
jnothman wants to merge 1 commit intostleary:masterfrom
Conversation
Contributor
|
Please see the README. |
Contributor
Author
|
Sorry I'm not really available to comment. I can't recall the context in which I used this project. |
Contributor
|
Thanks anyway |
Author
|
I suppose that's a better response, at least, than Please see the README. I still can't see in the README of that time what I was possibly meant to see there. |
Contributor
|
Yeah, at the time the readme mentioned he was looking for a maintainer
…On Wed, Mar 21, 2018, 22:34 Joel Nothman ***@***.***> wrote:
I suppose that's a better response, at least, than Please see the README.
I still can't see in the README
<https://github.com/stleary/JSON-java/blob/a75a060bc81bfe980bd172e985e3dd591e6c5e9b/README>
of that time what I was possibly meant to see there.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#108 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAXa1wTaxkec7-FP59ooPLSZIrnZ4ubPks5tgw28gaJpZM4C5jOV>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The special handling of the key
"content"inXML.toStringresults in highly unexpected behaviour in practice. Here is a patch that allows this key to be configurable. Indeed,nullis a good value for most cases, and I suggest it be made the default.