X Tutup
Skip to content

delete beta_neg_binomial_lccdf test#3118

Merged
WardBrian merged 2 commits intostan-dev:developfrom
lingium:fix/issue-3117-disable-bnb-lccdf-test
Oct 30, 2024
Merged

delete beta_neg_binomial_lccdf test#3118
WardBrian merged 2 commits intostan-dev:developfrom
lingium:fix/issue-3117-disable-bnb-lccdf-test

Conversation

@lingium
Copy link
Collaborator

@lingium lingium commented Oct 29, 2024 •
edited
Loading

Summary

As described by #3117, disable the test for beta_neg_binomial_lccdf.

Tests

NA

Side Effects

NA

Release notes

test/prob/beta_neg_binomial/beta_neg_binomial_ccdf_log_test.hpp will be deleted if merged.

Checklist

  • Copyright holder: Zhi Ling

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)

  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

@SteveBronder
Copy link
Collaborator

SteveBronder commented Oct 29, 2024

Instead of deleting it, can we try the following

  1. Make a beta_neg_binomial_tol_lccdf that exposes the tuning parameters.
  2. Test that with "nice numbers" that are easy to solve with a high tol and low iteration
  3. Have tests that use the expect_ad testing framework for the basic beta_neg_binomial_tol_lccdf

The prob testing framework is mostly to ensure that all the different varations of scalars and vectors can go into the distributions. But if we just want to test boundaries and things like that then I think it would be better for us to have those in mix/prob testing folder

@stan-buildbot
Copy link
Contributor

stan-buildbot commented Oct 29, 2024

Name Old Result New Result Ratio Performance change( 1 - new / old )
arma/arma.stan 0.38 0.34 1.11 10.14% faster
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.01 0.01 1.06 5.42% faster
gp_regr/gen_gp_data.stan 0.03 0.02 1.06 5.88% faster
gp_regr/gp_regr.stan 0.1 0.09 1.08 7.29% faster
sir/sir.stan 72.0 71.66 1.0 0.47% faster
irt_2pl/irt_2pl.stan 4.25 4.35 0.98 -2.45% slower
eight_schools/eight_schools.stan 0.06 0.06 0.92 -9.22% slower
pkpd/sim_one_comp_mm_elim_abs.stan 0.26 0.26 0.98 -1.76% slower
pkpd/one_comp_mm_elim_abs.stan 19.76 19.91 0.99 -0.74% slower
garch/garch.stan 0.45 0.41 1.09 8.53% faster
low_dim_gauss_mix/low_dim_gauss_mix.stan 2.81 2.63 1.07 6.14% faster
arK/arK.stan 1.81 1.72 1.05 5.16% faster
gp_pois_regr/gp_pois_regr.stan 2.86 2.76 1.04 3.5% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 8.84 8.37 1.06 5.35% faster
performance.compilation 184.21 190.06 0.97 -3.17% slower
Mean result: 1.0305470011559248

Jenkins Console Log
Blue Ocean
Commit hash: c148b0c9a356ceda75f6c6ee381d5d8ffc12bca0

Machine information No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal

CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 80
On-line CPU(s) list: 0-79
Thread(s) per core: 2
Core(s) per socket: 20
Socket(s): 2
NUMA node(s): 2
Vendor ID: GenuineIntel
CPU family: 6
Model: 85
Model name: Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz
Stepping: 4
CPU MHz: 2400.000
CPU max MHz: 3700.0000
CPU min MHz: 1000.0000
BogoMIPS: 4800.00
Virtualization: VT-x
L1d cache: 1.3 MiB
L1i cache: 1.3 MiB
L2 cache: 40 MiB
L3 cache: 55 MiB
NUMA node0 CPU(s): 0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46,48,50,52,54,56,58,60,62,64,66,68,70,72,74,76,78
NUMA node1 CPU(s): 1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,63,65,67,69,71,73,75,77,79
Vulnerability Gather data sampling: Mitigation; Microcode
Vulnerability Itlb multihit: KVM: Mitigation: VMX disabled
Vulnerability L1tf: Mitigation; PTE Inversion; VMX conditional cache flushes, SMT vulnerable
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Mitigation; IBRS
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; IBRS; IBPB conditional; STIBP conditional; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT vulnerable
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd mba ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req pku ospke md_clear flush_l1d arch_capabilities

G++:
g++ (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Clang:
clang version 10.0.0-4ubuntu1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

@lingium
Copy link
Collaborator Author

lingium commented Oct 30, 2024

Thanks to Steve's suggestion, after some debugging I found certain magic numbers and now the time for this test should be the same as other distributions. Let’s see how it works on the Jenkins machine.

@stan-buildbot
Copy link
Contributor

stan-buildbot commented Oct 30, 2024

Name Old Result New Result Ratio Performance change( 1 - new / old )
arma/arma.stan 0.36 0.33 1.08 7.12% faster
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.01 0.01 0.99 -0.83% slower
gp_regr/gen_gp_data.stan 0.03 0.02 1.24 19.27% faster
gp_regr/gp_regr.stan 0.1 0.11 0.92 -9.23% slower
sir/sir.stan 70.02 71.01 0.99 -1.41% slower
irt_2pl/irt_2pl.stan 4.14 4.3 0.96 -3.92% slower
eight_schools/eight_schools.stan 0.06 0.06 0.95 -5.63% slower
pkpd/sim_one_comp_mm_elim_abs.stan 0.25 0.26 0.97 -2.62% slower
pkpd/one_comp_mm_elim_abs.stan 19.4 18.71 1.04 3.57% faster
garch/garch.stan 0.43 0.4 1.07 6.36% faster
low_dim_gauss_mix/low_dim_gauss_mix.stan 2.73 2.58 1.06 5.53% faster
arK/arK.stan 1.79 1.7 1.05 4.84% faster
gp_pois_regr/gp_pois_regr.stan 2.93 2.69 1.09 8.29% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 8.77 8.34 1.05 4.94% faster
performance.compilation 183.43 184.62 0.99 -0.65% slower
Mean result: 1.0294817958764928

Jenkins Console Log
Blue Ocean
Commit hash: c148b0c9a356ceda75f6c6ee381d5d8ffc12bca0

Machine information No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal

CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 80
On-line CPU(s) list: 0-79
Thread(s) per core: 2
Core(s) per socket: 20
Socket(s): 2
NUMA node(s): 2
Vendor ID: GenuineIntel
CPU family: 6
Model: 85
Model name: Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz
Stepping: 4
CPU MHz: 2400.000
CPU max MHz: 3700.0000
CPU min MHz: 1000.0000
BogoMIPS: 4800.00
Virtualization: VT-x
L1d cache: 1.3 MiB
L1i cache: 1.3 MiB
L2 cache: 40 MiB
L3 cache: 55 MiB
NUMA node0 CPU(s): 0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46,48,50,52,54,56,58,60,62,64,66,68,70,72,74,76,78
NUMA node1 CPU(s): 1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,63,65,67,69,71,73,75,77,79
Vulnerability Gather data sampling: Mitigation; Microcode
Vulnerability Itlb multihit: KVM: Mitigation: VMX disabled
Vulnerability L1tf: Mitigation; PTE Inversion; VMX conditional cache flushes, SMT vulnerable
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Mitigation; IBRS
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; IBRS; IBPB conditional; STIBP conditional; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT vulnerable
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd mba ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req pku ospke md_clear flush_l1d arch_capabilities

G++:
g++ (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Clang:
clang version 10.0.0-4ubuntu1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

@lingium
Copy link
Collaborator Author

lingium commented Oct 30, 2024

Nice, now the test will not affect continuous integration.
image

WardBrian
WardBrian approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@WardBrian WardBrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, it is indeed much faster!

@WardBrian WardBrian merged commit 8ab9760 into stan-dev:develop Oct 30, 2024
@lingium lingium deleted the fix/issue-3117-disable-bnb-lccdf-test branch October 30, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WardBrian WardBrian WardBrian approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lingium @SteveBronder @stan-buildbot @WardBrian
X Tutup