X Tutup
Skip to content

use a seperate class for csr_matrix adjoint#3053

Merged
SteveBronder merged 4 commits intodevelopfrom
fix/csr-matrix-seperate-vari
Apr 26, 2024
Merged

use a seperate class for csr_matrix adjoint#3053
SteveBronder merged 4 commits intodevelopfrom
fix/csr-matrix-seperate-vari

Conversation

@SteveBronder
Copy link
Collaborator

@SteveBronder SteveBronder commented Apr 24, 2024

Summary

Tries to fix the linking issue again in stan-dev/rstanarm#620

Tests

Same tests as before

@WardBrian or @bgoodri can you try using this version in stanheaders to see what happens?

Checklist

  • Copyright holder: (fill in copyright holder information)

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)

  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

@WardBrian
Copy link
Member

WardBrian commented Apr 24, 2024

This one worked. I took @bgoodri’s provisional stanheaders that had our last attempt, dropped this file in, and rstanarm built on Windows

@bgoodri
Copy link
Contributor

bgoodri commented Apr 25, 2024

OK. This is a fine workaround, although it is probably a bug in the C++ compiler or linker if we could come up with a minimal reproducible example.

@SteveBronder
Copy link
Collaborator Author

SteveBronder commented Apr 25, 2024

Perfect let me read this over one more time in the AM and we can merge.

@WardBrian
Copy link
Member

WardBrian commented Apr 25, 2024

My first attempt at a reproducible example outside of the Stan codebase failed. It's still not entirely clear to me which ingredients are necessary to get the behavior

@stan-buildbot
Copy link
Contributor

stan-buildbot commented Apr 25, 2024

Name Old Result New Result Ratio Performance change( 1 - new / old )
arma/arma.stan 0.21 0.29 0.74 -35.63% slower
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.01 0.01 0.94 -6.82% slower
gp_regr/gen_gp_data.stan 0.02 0.02 1.0 0.18% faster
gp_regr/gp_regr.stan 0.12 0.11 1.04 3.96% faster
sir/sir.stan 80.65 80.59 1.0 0.07% faster
irt_2pl/irt_2pl.stan 4.16 4.08 1.02 1.88% faster
eight_schools/eight_schools.stan 0.06 0.05 1.01 1.4% faster
pkpd/sim_one_comp_mm_elim_abs.stan 0.25 0.26 0.99 -0.87% slower
pkpd/one_comp_mm_elim_abs.stan 19.04 19.14 0.99 -0.52% slower
garch/garch.stan 0.48 0.47 1.02 1.78% faster
low_dim_gauss_mix/low_dim_gauss_mix.stan 2.89 2.88 1.0 0.32% faster
arK/arK.stan 1.67 1.71 0.98 -2.48% slower
gp_pois_regr/gp_pois_regr.stan 2.58 2.56 1.01 0.86% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 9.6 9.45 1.02 1.63% faster
performance.compilation 184.18 191.16 0.96 -3.79% slower
Mean result: 0.9815139635944256

Jenkins Console Log
Blue Ocean
Commit hash: c6019921b2ba008c773ee9e6eb053db724a2d774

Machine information No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal

CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 80
On-line CPU(s) list: 0-79
Thread(s) per core: 2
Core(s) per socket: 20
Socket(s): 2
NUMA node(s): 2
Vendor ID: GenuineIntel
CPU family: 6
Model: 85
Model name: Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz
Stepping: 4
CPU MHz: 2400.000
CPU max MHz: 3700.0000
CPU min MHz: 1000.0000
BogoMIPS: 4800.00
Virtualization: VT-x
L1d cache: 1.3 MiB
L1i cache: 1.3 MiB
L2 cache: 40 MiB
L3 cache: 55 MiB
NUMA node0 CPU(s): 0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46,48,50,52,54,56,58,60,62,64,66,68,70,72,74,76,78
NUMA node1 CPU(s): 1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,63,65,67,69,71,73,75,77,79
Vulnerability Gather data sampling: Mitigation; Microcode
Vulnerability Itlb multihit: KVM: Mitigation: VMX disabled
Vulnerability L1tf: Mitigation; PTE Inversion; VMX conditional cache flushes, SMT vulnerable
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Retbleed: Mitigation; IBRS
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; IBRS, IBPB conditional, STIBP conditional, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT vulnerable
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd mba ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req pku ospke md_clear flush_l1d arch_capabilities

G++:
g++ (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Clang:
clang version 10.0.0-4ubuntu1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

WardBrian
WardBrian previously approved these changes Apr 25, 2024
View reviewed changes
@SteveBronder
Copy link
Collaborator Author

SteveBronder commented Apr 25, 2024

@WardBrian added some docs, think this is good now

@stan-buildbot
Copy link
Contributor

stan-buildbot commented Apr 25, 2024

Name Old Result New Result Ratio Performance change( 1 - new / old )
arma/arma.stan 0.21 0.18 1.17 14.66% faster
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.01 0.01 0.98 -2.02% slower
gp_regr/gen_gp_data.stan 0.02 0.02 1.02 2.18% faster
gp_regr/gp_regr.stan 0.11 0.1 1.04 3.56% faster
sir/sir.stan 77.75 76.92 1.01 1.06% faster
irt_2pl/irt_2pl.stan 3.91 3.92 1.0 -0.07% slower
eight_schools/eight_schools.stan 0.05 0.05 1.05 4.92% faster
pkpd/sim_one_comp_mm_elim_abs.stan 0.25 0.25 1.0 -0.28% slower
pkpd/one_comp_mm_elim_abs.stan 17.97 18.6 0.97 -3.5% slower
garch/garch.stan 0.45 0.46 0.99 -1.39% slower
low_dim_gauss_mix/low_dim_gauss_mix.stan 2.77 2.83 0.98 -2.18% slower
arK/arK.stan 1.61 1.6 1.01 0.93% faster
gp_pois_regr/gp_pois_regr.stan 2.49 2.47 1.01 0.9% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 9.04 8.92 1.01 1.34% faster
performance.compilation 175.88 175.79 1.0 0.05% faster
Mean result: 1.0155958188868495

Jenkins Console Log
Blue Ocean
Commit hash: 13017193216fe150e9a8fadbc7b3f9cb71f8a58d

Machine information No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal

CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 80
On-line CPU(s) list: 0-79
Thread(s) per core: 2
Core(s) per socket: 20
Socket(s): 2
NUMA node(s): 2
Vendor ID: GenuineIntel
CPU family: 6
Model: 85
Model name: Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz
Stepping: 4
CPU MHz: 2400.000
CPU max MHz: 3700.0000
CPU min MHz: 1000.0000
BogoMIPS: 4800.00
Virtualization: VT-x
L1d cache: 1.3 MiB
L1i cache: 1.3 MiB
L2 cache: 40 MiB
L3 cache: 55 MiB
NUMA node0 CPU(s): 0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46,48,50,52,54,56,58,60,62,64,66,68,70,72,74,76,78
NUMA node1 CPU(s): 1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,63,65,67,69,71,73,75,77,79
Vulnerability Gather data sampling: Mitigation; Microcode
Vulnerability Itlb multihit: KVM: Mitigation: VMX disabled
Vulnerability L1tf: Mitigation; PTE Inversion; VMX conditional cache flushes, SMT vulnerable
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Retbleed: Mitigation; IBRS
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; IBRS, IBPB conditional, STIBP conditional, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT vulnerable
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd mba ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req pku ospke md_clear flush_l1d arch_capabilities

G++:
g++ (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Clang:
clang version 10.0.0-4ubuntu1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

@SteveBronder SteveBronder merged commit 9f759e1 into develop Apr 26, 2024
@WardBrian WardBrian deleted the fix/csr-matrix-seperate-vari branch August 5, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WardBrian WardBrian WardBrian approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SteveBronder @WardBrian @bgoodri @stan-buildbot
X Tutup