Add denoising methods to class PrincipalComponents#91
Merged
tboggs merged 3 commits intospectralpython:masterfrom Aug 19, 2019
Merged
Add denoising methods to class PrincipalComponents#91tboggs merged 3 commits intospectralpython:masterfrom
tboggs merged 3 commits intospectralpython:masterfrom
Conversation
Contributor
Author
|
It looks like the checks aren't failing because of anything I did -- I've run them on an unaltered branch and they fail there, too, in the exact same way. I think the issue is this one: https://travis-ci.community/t/issue-with-python-2-6-on-linux/3861 The suggested fix of adding dist: trusty to the travis.yml file works. I'm not sure if this is the actual fix you wish to implement, or if you want to no longer support Python 2.6 and Python 3.3, instead. |
Member
|
Hi Gemma, Thanks for the addition! I'll accept the merge request shortly Also, I'm long overdue for pushing out an updated release so I'll try to get that done within the next week or so. Thanks, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there!
I wrote a couple of denoising methods into the PrincipalComponents class, with a format similar to the ones in the MNFResult class. I'm currently using MNF on some data I'm working on, and I find it useful to be able to swiftly compare the MNF denoising to an equivalent PCA denoising.
This is my first ever pull request, just so you know, so I hope I'm going about this in basically the right way. Tips are welcome.
Thanks!
--Gemma