Fix #65 by having block_actions as the default when type is missing in constraints#67
Merged
seratch merged 2 commits intoslackapi:mainfrom Sep 9, 2020
Merged
Conversation
…issing in constraints
seratch
commented
Sep 9, 2020
Contributor
Author
seratch
left a comment
seratch
left a comment
There was a problem hiding this comment.
comments for reviewers
| return workflow_step_edit(constraints["callback_id"], asyncio) | ||
|
|
||
| raise BoltError(f"type: {action_type} is unsupported") | ||
| elif "action_id" in constraints: |
Contributor
Author
There was a problem hiding this comment.
This is the key change.
| elif isinstance(str_or_pattern, Pattern): | ||
| pattern: Pattern = str_or_pattern | ||
| return pattern.search(input) | ||
| return pattern.search(input) is not None |
Contributor
Author
There was a problem hiding this comment.
Just to make the type consistent - bool
Codecov Report
@@ Coverage Diff @@
## main #67 +/- ##
==========================================
+ Coverage 77.61% 77.75% +0.13%
==========================================
Files 123 123
Lines 3404 3416 +12
==========================================
+ Hits 2642 2656 +14
+ Misses 762 760 -2
Continue to review full report at Codecov.
|
misscoded
approved these changes
Sep 9, 2020
mwbrooks
approved these changes
Sep 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes #65 by allowing to omit having
"type": "block_actions"in constraints forapp.action. Also, it enables the framework to considerblock_idas one of the conditions for listener executions.Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapterRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/run_tests.shafter making the changes.