X Tutup
Skip to content

Fix #132 by handling requestContext in AWS Lambda payloads#133

Merged
seratch merged 1 commit intoslackapi:mainfrom
seratch:issue-132-lambda
Oct 29, 2020
Merged

Fix #132 by handling requestContext in AWS Lambda payloads#133
seratch merged 1 commit intoslackapi:mainfrom
seratch:issue-132-lambda

Conversation

@seratch
Copy link
Contributor

@seratch seratch commented Oct 29, 2020

This pull request fixes #132 by updating the AWS Lambda handler to be compatible with all the patterns in the environment.

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added bug Something isn't working area:adapter labels Oct 29, 2020
@seratch seratch added this to the 0.9.6b0 milestone Oct 29, 2020
@codecov-io
Copy link

Codecov Report

Merging #133 into main will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #133   +/-   ##
=======================================
  Coverage   91.23%   91.24%           
=======================================
  Files         148      148           
  Lines        4222     4224    +2     
=======================================
+ Hits         3852     3854    +2     
  Misses        370      370           
Impacted Files Coverage Δ
slack_bolt/adapter/aws_lambda/handler.py 92.53% <100.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bea7fc7...c9ce887. Read the comment docs.

@seratch seratch merged commit 3f67a08 into slackapi:main Oct 29, 2020
@seratch seratch deleted the issue-132-lambda branch October 29, 2020 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:adapter bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SlackRequestHandler does not work on Lambda

2 participants

X Tutup