feat: Add --chat-server-host option for WebSocket server binding#6609
Open
AusDavo wants to merge 1 commit intosimplex-chat:stablefrom
Open
feat: Add --chat-server-host option for WebSocket server binding#6609AusDavo wants to merge 1 commit intosimplex-chat:stablefrom
AusDavo wants to merge 1 commit intosimplex-chat:stablefrom
Conversation
Add ability to specify the host address for the WebSocket chat server to bind to, rather than being hardcoded to 127.0.0.1. This is useful for running the chat server in containers or VMs where connections need to come from outside localhost. Usage: simplex-chat -p 5225 --chat-server-host 0.0.0.0 When --chat-server-host is not specified, defaults to 127.0.0.1 for backwards compatibility. Use 0.0.0.0 to bind to all interfaces. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--chat-server-host HOSToption to specify the bind address for the WebSocket chat server127.0.0.1for backwards compatibility0.0.0.0to bind to all interfaces (useful for Docker/container deployments)Use Case
When running
simplex-chatin a container, the WebSocket server needs to be accessible from outside localhost. Currently this requires patching the binary.Example
simplex-chat -p 5225 --chat-server-host 0.0.0.0
Test plan
--chat-server-host 0.0.0.0binds to all interfaces-pflag still works