Opt in to accept empty subject confirmation data.#840
Open
m0ark wants to merge 8 commits intosimplesamlphp:masterfrom
Open
Opt in to accept empty subject confirmation data.#840m0ark wants to merge 8 commits intosimplesamlphp:masterfrom
m0ark wants to merge 8 commits intosimplesamlphp:masterfrom
Conversation
added 3 commits
April 25, 2018 08:19
…viour is unchanged to ensure SAML sso profiles are handled properly.
…viour is unchanged to ensure SAML sso profiles are handled properly.
Member
|
So this is a variant of #825. On the code itself my comment would be that I do want to avoid negatively worded parameters, so not |
Codecov Report
@@ Coverage Diff @@
## master #840 +/- ##
============================================
- Coverage 38.36% 38.35% -0.02%
- Complexity 3385 3386 +1
============================================
Files 128 128
Lines 9633 9636 +3
============================================
Hits 3696 3696
- Misses 5937 5940 +3 |
tvdijen
force-pushed
the
master
branch
3 times, most recently
from
1c686ab to
eb20457
Compare
tvdijen
force-pushed
the
master
branch
2 times, most recently
from
08ebb9c to
64fca25
Compare
tvdijen
force-pushed
the
master
branch
2 times, most recently
from
7a53fc8 to
d73ae47
Compare
tvdijen
force-pushed
the
master
branch
2 times, most recently
from
e5c0e21 to
d5616df
Compare
tvdijen
force-pushed
the
master
branch
3 times, most recently
from
2e6ab04 to
32f9acc
Compare
tvdijen
force-pushed
the
master
branch
3 times, most recently
from
c743c9a to
fc71570
Compare
tvdijen
force-pushed
the
master
branch
8 times, most recently
from
7b173cf to
3326beb
Compare
tvdijen
force-pushed
the
master
branch
2 times, most recently
from
8ac729b to
a16cf6e
Compare
tvdijen
force-pushed
the
master
branch
2 times, most recently
from
fc454de to
7ac76ae
Compare
tvdijen
force-pushed
the
master
branch
6 times, most recently
from
29f7b69 to
1a911ce
Compare
tvdijen
force-pushed
the
master
branch
3 times, most recently
from
c7c8357 to
fdbe001
Compare
tvdijen
force-pushed
the
master
branch
8 times, most recently
from
3b5f5ba to
96357ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default the behaviour is unchanged to ensure SAML sso profiles are handled properly.
Enables utilization for processing other SAML messages, e.g. attribute queries, where SubjectConfirmationData is optional.