Codecov Report

Merging #1438 (bfaeb14) into master (7a1d8e6) will decrease coverage by 6.96%.
The diff coverage is 33.33%.

❗ Current head bfaeb14 differs from pull request most recent head aa21c42. Consider uploading reports for the commit aa21c42 to get more accurate results

@@             Coverage Diff              @@
##             master    #1438      +/-   ##
============================================
- Coverage     45.48%   38.53%   -6.96%     
+ Complexity     3692     3482     -210     
============================================
  Files           158      139      -19     
  Lines         12292    10373    -1919     
============================================
- Hits           5591     3997    -1594     
+ Misses         6701     6376     -325     

I started looking into this and #371

Another option these days is to use the Symfony logging
https://symfony.com/doc/current/logging.html

I am still looking at if trying to use the injection stuff might help. I have a little example of using the monolog to back the logs but it might make sense to use the Symfony logging so we can slot in whatever we want there and SSP is somewhat shielded from it.

OTOH if we gain enough to invest the time into this right now or focus on other enhancements and 3.x first.

I mainly got here looking at some of the older PRs.

I'm all in favour of using symfony for this!
Once we release 2.5, I want to force-push that to master and store the current master-branch in a backup-branch. Then we can start working on this on a new 3.0 branch