Add Metadata Directory of FlatFiles support#1292
Add Metadata Directory of FlatFiles support#1292pkolmann wants to merge 3 commits intosimplesamlphp:masterfrom
Conversation
The MetaData Files usually are quite long and if you need to change something it's quite bulky to handle them. Diffing between different SPs is also not too easy. Thats why I added the support for Metadata config directories. Every SP goes into it's own flatfile.
Codecov Report
@@ Coverage Diff @@
## master #1292 +/- ##
============================================
+ Coverage 37.85% 38.00% +0.15%
- Complexity 3431 3446 +15
============================================
Files 129 130 +1
Lines 9738 9778 +40
============================================
+ Hits 3686 3716 +30
- Misses 6052 6062 +10 |
|
@tvdijen can you please advise if this change is worth accepting? |
|
Thanks @pkolmann!! I am |
|
@tvdijen could you take another look at this please. |
tvdijen
force-pushed
the
master
branch
3 times, most recently
from
1c686ab to
eb20457
Compare
tvdijen
force-pushed
the
master
branch
2 times, most recently
from
08ebb9c to
64fca25
Compare
tvdijen
force-pushed
the
master
branch
2 times, most recently
from
7a53fc8 to
d73ae47
Compare
tvdijen
force-pushed
the
master
branch
2 times, most recently
from
e5c0e21 to
d5616df
Compare
tvdijen
force-pushed
the
master
branch
3 times, most recently
from
2e6ab04 to
32f9acc
Compare
tvdijen
force-pushed
the
master
branch
6 times, most recently
from
7e3ea19 to
2523634
Compare
|
@tvdijen Any luck with merging this PR? This would very handy to have for larger installations... |
tvdijen
force-pushed
the
master
branch
2 times, most recently
from
8ac729b to
a16cf6e
Compare
tvdijen
force-pushed
the
master
branch
2 times, most recently
from
fc454de to
7ac76ae
Compare
tvdijen
force-pushed
the
master
branch
6 times, most recently
from
29f7b69 to
1a911ce
Compare
tvdijen
force-pushed
the
master
branch
3 times, most recently
from
c7c8357 to
fdbe001
Compare
tvdijen
force-pushed
the
master
branch
8 times, most recently
from
3b5f5ba to
96357ee
Compare
tvdijen
force-pushed
the
master
branch
3 times, most recently
from
cf19ac3 to
d6b52c5
Compare
|
There is also an issue submitted wanting a similar functionality for the XML files for SPs. A comment over on that issue is calling for a more generic solution to allow both flatfile and xml to be loaded on demand: #1368 (comment) I mention this because the comment may not have been seen on this thread. I've been looking at this PR and the code a little bit in recent days. |
|
I had a bit of a play around with this and ended up with very similar code to what is here though trying to handle xml files as well if they are found in the metadata/subdirectory.d directory. I am not sure what I have in the below branch makes complete sense as I am very new to the SSP code base. It does seem that this PR could be extended to check for php files and do something on them and something else if an xml file was found, otherwise maybe just report an ignored file? |
|
Sorry about the wait. I have merged a PR with this functionality into the simplesamlphp-2.3 branch and master. The patch should also back port to a 2.2 release reasonably well if you would like to take it for a test run. |
4 participants
I like to split up long config files to split config files.
The MetaData Files usually are quite long and if you need to change
something it's quite bulky to handle them. Diffing between different SPs
is also not too easy.
Thats why I added the support for Metadata config directories. Every SP
goes into it's own flatfile.