errorreport with unfilled fields won't send an email#1237
errorreport with unfilled fields won't send an email#1237BaranekD wants to merge 1 commit intosimplesamlphp:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1237 +/- ##
=========================================
Coverage 37.05% 37.05%
Complexity 3759 3759
=========================================
Files 136 136
Lines 11462 11462
=========================================
Hits 4247 4247
Misses 7215 7215Continue to review full report at Codecov.
|
|
Thanks a lot for your contribution, @BaranekD! This one is a bit hard to decide on, because we definitely see legitimate error reports with the exception and URL not set. In the end, those fields being not set means something went really wrong, but not necessarily that the message is spam, since the data may still have been successfully recovered. Of course, lacking a backtrace means it's almost impossible for us to figure out where did that error originate, and fix it. I'd say the most clear case here is when loading the exception data from the session fails, as that might indeed indicate that this could be automated in any way, for whatever purpose. But if loading the data succeeds, I think then we should send the report, even if parts of it are missing. Also, bear in mind that if someone really wants to use this to spam, it would be simple to circumvent your check by manually inducing an error (e.g. page not found). |
1c686ab to
eb20457
Compare
08ebb9c to
64fca25
Compare
7a53fc8 to
d73ae47
Compare
e5c0e21 to
d5616df
Compare
|
I understand the issue but I agree that this might not be the best solution. What kind of reports are you getting that you want to prevent? |
2e6ab04 to
32f9acc
Compare
7e3ea19 to
2523634
Compare
60239d7 to
3f839d4
Compare
7b173cf to
3326beb
Compare
8ac729b to
a16cf6e
Compare
fc454de to
7ac76ae
Compare
29f7b69 to
1a911ce
Compare
c7c8357 to
fdbe001
Compare
3b5f5ba to
96357ee
Compare
d7f25d2 to
41d9254
Compare
This PR does not allow to send empty errorreports. It can help before spamming unwanted reports.