Update hard coded macro defines to constexpr variables in .cpp files.#2064
Draft
Dimi1010 wants to merge 4 commits intoseladb:devfrom
Draft
Update hard coded macro defines to constexpr variables in .cpp files.#2064Dimi1010 wants to merge 4 commits intoseladb:devfrom
Dimi1010 wants to merge 4 commits intoseladb:devfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2064 +/- ##
=======================================
Coverage 83.81% 83.81%
=======================================
Files 313 313
Lines 55676 55669 -7
Branches 11606 11570 -36
=======================================
- Hits 46665 46660 -5
+ Misses 7810 7807 -3
- Partials 1201 1202 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates some of the hardcoded macro constants to
constexprvariables.