Clean-up embedded tests

vmuriart · vmuriart · commit e7c94dfd7746 · 2017-02-21T11:18:03.000-07:00
Clean-up embedded tests comments and variable types Remove TestFixture attribute. Optional since NUnit 2.5 https://nunit.org/index.php?p=testFixture&r=2.6.4
diff --git a/src/embed_tests/dynamic.cs b/src/embed_tests/dynamic.cs
@@ -5,7 +5,6 @@
 
 namespace Python.EmbeddingTest
 {
-    [TestFixture]
     public class dynamicTest
     {
         private Py.GILState gil;
@@ -23,16 +22,16 @@ public void TearDown()
         }
 
         /// <summary>
-        /// Set the attribute of a pyobject with a .NET object.
+        /// Set the attribute of a PyObject with a .NET object.
         /// </summary>
         [Test]
         public void AssignObject()
         {
-            StringBuilder stream = new StringBuilder();
+            var stream = new StringBuilder();
             dynamic sys = Py.Import("sys");
             sys.testattr = stream;
             // Check whether there are the same object.
-            var _stream = sys.testattr.AsManagedObject(typeof(StringBuilder));
+            dynamic _stream = sys.testattr.AsManagedObject(typeof(StringBuilder));
             Assert.AreEqual(_stream, stream);
 
             PythonEngine.RunSimpleString(
@@ -42,7 +41,7 @@ public void AssignObject()
         }
 
         /// <summary>
-        /// Set the attribute of a pyobject to null.
+        /// Set the attribute of a PyObject to null.
         /// </summary>
         [Test]
         public void AssignNone()
@@ -76,24 +75,24 @@ public void AssignPyObject()
         [Test]
         public void PassObjectInPython()
         {
-            StringBuilder stream = new StringBuilder();
+            var stream = new StringBuilder();
             dynamic sys = Py.Import("sys");
             sys.testattr1 = stream;
 
-            //Pass the .NET object in Python side
+            // Pass the .NET object in Python side
             PythonEngine.RunSimpleString(
                 "import sys\n" +
                 "sys.testattr2 = sys.testattr1\n"
             );
 
-            //Compare in Python
+            // Compare in Python
             PythonEngine.RunSimpleString(
                 "import sys\n" +
                 "sys.testattr3 = sys.testattr1 is sys.testattr2\n"
             );
             Assert.AreEqual(sys.testattr3.ToString(), "True");
 
-            //Compare in .NET
+            // Compare in .NET
             Assert.AreEqual(sys.testattr1, sys.testattr2);
         }
 
@@ -103,19 +102,19 @@ public void PassObjectInPython()
         [Test]
         public void PassPyObjectInNet()
         {
-            StringBuilder stream = new StringBuilder();
+            var stream = new StringBuilder();
             dynamic sys = Py.Import("sys");
             sys.testattr1 = stream;
             sys.testattr2 = sys.testattr1;
 
-            //Compare in Python
+            // Compare in Python
             PyObject res = PythonEngine.RunString(
                 "import sys\n" +
                 "sys.testattr3 = sys.testattr1 is sys.testattr2\n"
             );
             Assert.AreEqual(sys.testattr3.ToString(), "True");
 
-            //Compare in .NET
+            // Compare in .NET
             Assert.AreEqual(sys.testattr1, sys.testattr2);
         }
     }
diff --git a/src/embed_tests/pyimport.cs b/src/embed_tests/pyimport.cs
@@ -17,7 +17,6 @@ namespace Python.EmbeddingTest
     /// | | - __init__.py
     /// | | - one.py
     /// </remarks>
-    [TestFixture]
     public class PyImportTest
     {
         private IntPtr gs;
diff --git a/src/embed_tests/pyinitialize.cs b/src/embed_tests/pyinitialize.cs
@@ -1,3 +1,4 @@
+using System;
 using NUnit.Framework;
 using Python.Runtime;
 
@@ -51,24 +52,24 @@ public static void LoadSpecificArgs()
         //[Ignore("System.ArgumentException : Cannot pass a GCHandle across AppDomains")]
         public void ReInitialize()
         {
-            string code = "from System import Int32\n";
+            var code = "from System import Int32\n";
             PythonEngine.Initialize();
             using (Py.GIL())
             {
-                //import any class or struct from .NET
+                // Import any class or struct from .NET
                 PythonEngine.RunSimpleString(code);
             }
             PythonEngine.Shutdown();
 
             PythonEngine.Initialize();
             using (Py.GIL())
             {
-                //Import a class/struct from .NET
-                //This class/struct must be imported during the first initialization.
+                // Import a class/struct from .NET
+                // This class/struct must be imported during the first initialization.
                 PythonEngine.RunSimpleString(code);
-                //Create an instance of the class/struct
-                //System.OverflowException Exception will be raised here.
-                //If replacing int with Int64, OverflowException will be replaced with AppDomain exception.
+                // Create an instance of the class/struct
+                // System.OverflowException Exception will be raised here.
+                // If replacing int with Int64, OverflowException will be replaced with AppDomain exception.
                 PythonEngine.RunSimpleString("Int32(1)");
             }
             PythonEngine.Shutdown();
diff --git a/src/embed_tests/pyiter.cs b/src/embed_tests/pyiter.cs
@@ -1,3 +1,4 @@
+using System;
 using System.Collections.Generic;
 using NUnit.Framework;
 using Python.Runtime;
diff --git a/src/embed_tests/pylong.cs b/src/embed_tests/pylong.cs
@@ -1,3 +1,4 @@
+using System;
 using NUnit.Framework;
 using Python.Runtime;
 
diff --git a/src/embed_tests/pyobject.cs b/src/embed_tests/pyobject.cs
@@ -1,3 +1,4 @@
+using System;
 using NUnit.Framework;
 using Python.Runtime;
 
diff --git a/src/embed_tests/pythonexception.cs b/src/embed_tests/pythonexception.cs
@@ -11,7 +11,6 @@ namespace Python.EmbeddingTest
     /// Keeping this in the old-style SetUp/TearDown
     /// to ensure that setup still works.
     /// </remarks>
-    [TestFixture]
     public class PythonExceptionTest
     {
         private IntPtr gs;
diff --git a/src/embed_tests/pytuple.cs b/src/embed_tests/pytuple.cs
@@ -1,3 +1,4 @@
+using System;
 using NUnit.Framework;
 using Python.Runtime;
 

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,6 @@ namespace Python.EmbeddingTest`
`17`	`17`	`/// \| \| - __init__.py`
`18`	`18`	`/// \| \| - one.py`
`19`	`19`	`/// </remarks>`
`20`		`- [TestFixture]`
`21`	`20`	`public class PyImportTest`
`22`	`21`	`{`
`23`	`22`	`private IntPtr gs;`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+using System;`
`1`	`2`	`using System.Collections.Generic;`
`2`	`3`	`using NUnit.Framework;`
`3`	`4`	`using Python.Runtime;`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,6 @@ namespace Python.EmbeddingTest`
`11`	`11`	`/// Keeping this in the old-style SetUp/TearDown`
`12`	`12`	`/// to ensure that setup still works.`
`13`	`13`	`/// </remarks>`
`14`		`- [TestFixture]`
`15`	`14`	`public class PythonExceptionTest`
`16`	`15`	`{`
`17`	`16`	`private IntPtr gs;`