Allow Admin/Owner to Opt Out of Auto-Approval

Summary

This PR implements an option for admin and owner accounts to disable auto-approval of their own requests, addressing a long-standing feature request. Admin requests can now go through the normal pending → approved flow, enabling integration with third-party tools and manual queue management.

Closes #3926

Problem

Currently, any request made by an admin or owner account is automatically approved and begins processing immediately. This behavior:

1. Prevents wishlist functionality - Admins cannot maintain a queue of desired media
2. Breaks third-party tool integration - Tools that intercept pending requests (for availability checking, approval workflows, etc.) cannot process admin requests
3. Limits admin flexibility - Features are more restricted on accounts with greater permissions

Solution

Modified the permission system to treat auto-approve permissions explicitly for admin users, rather than granting them implicitly via the admin role.

Key Changes

1. server/lib/permissions.ts

   • Added isAutoApprovePermission() helper function
   • Modified hasPermission() to NOT bypass auto-approve permission checks for admin users
   • Preserved admin bypass for all other permission types
   • Restored permissions === 0 early return for isAuthenticated() with no args

2. server/entity/MediaRequest.ts

   • Removed Permission.MANAGE_REQUESTS from auto-approval status check
   • Admin requests now go to PENDING unless explicit auto-approve permissions are set

3. server/routes/user/usersettings.ts

   • Added special handling for owner (ID 1) to modify their own auto-approve permissions
   • Protected all other permissions from self-modification

4. Frontend Components

   • Updated PermissionOption to allow owner to toggle auto-approve in UI
   • Updated request modals to accurately reflect auto-approval status

Permission Behavior Matrix

How to Use

For Admins Who Want Pending Requests

1. Go to Settings → Users → [Your User] → Permissions
2. Uncheck the auto-approve permissions:
   • Auto-Approve
   • Auto-Approve Movies
   • Auto-Approve Series
   • (And 4K variants if applicable)
3. Save changes

New requests will now go to Pending status instead of being automatically approved.

For Admins Who Want Original Behavior

No action needed. Ensure auto-approve permissions remain checked (they are granted by default for new admin accounts).

Testing Performed

Functional Tests

• Non-admin users can log in (/auth/me returns 200)
• Admin users can log in
• Admin with auto-approve disabled → requests go to PENDING
• Admin with auto-approve enabled → requests auto-approve
• Admin can still approve/reject other users' requests
• Admin can still manage users, settings, issues
• Owner can toggle auto-approve permissions in UI
• Owner cannot modify other permissions on themselves
• Notifications still work for admins

Edge Cases Verified

• hasPermission(0, ...) returns true (any logged-in user)
• hasPermission([], ...) returns true (empty array)
• hasPermission([AUTO_APPROVE], ...) requires explicit bit for admin
• hasPermission([MANAGE_REQUESTS], ...) allows admin bypass

Comprehensive Permission Audit

All permission behaviors preserved with one intentional change:

Breaking Changes

None. This is backwards-compatible:

• Existing admin accounts retain their current permissions
• Auto-approve behavior unchanged unless explicitly modified by user
• All administrative functions continue to work