X Tutup
Skip to content
This repository was archived by the owner on Feb 15, 2026. It is now read-only.

feat: request 4K media with the title card#3636

Open
OwsleyJr wants to merge 2 commits intodevelopfrom
feat/discover-4krequest
Open

feat: request 4K media with the title card#3636
OwsleyJr wants to merge 2 commits intodevelopfrom
feat/discover-4krequest

Conversation

@OwsleyJr
Copy link
Collaborator

@OwsleyJr OwsleyJr commented Oct 2, 2023

Description

The main focus of this PR is to give the user the ability to request 4K media on the discover screen. Before, users were only able to request non-4K media through the title card. Now if non-4K media is already available and the server has 4K requesting enabled, the 4K request button will show. Also, a status badge will now show if you only have 4K media available.

There are some cases where the user might not have a non-4K server and two 4K servers so a check was added for this scenario.

  • Movie enabled and series enabled boolean added to mirror the similar 4K booleans.
  • 4K request modal was added to the title card.

Screenshot (if UI-related)

Screenshot 2023-10-02 at 12 52 05 PM

To-Dos

  • Successful build yarn build

Issues Fixed or Closed

@cypress
Copy link

cypress bot commented Oct 2, 2023

overseerr    Run #2413

Run Properties:  status check passed Passed #2413  •  git commit 3369adfb9a: feat: request 4K media with the title card
Project overseerr
Branch Review refs/pull/3636/merge
Run status status check passed Passed #2413
Run duration 02m 26s
Commit git commit 3369adfb9a: feat: request 4K media with the title card
Committer Brandon Cohen
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 28
View all changes introduced in this branch ↗︎

@liquid-ion
Copy link

liquid-ion commented Mar 22, 2024

.

was on version that didn't contain this update. sorry everyone

@OwsleyJr
Copy link
Collaborator Author

OwsleyJr commented Mar 22, 2024

I don't think this feature fully works. It does on the "Discover" tab, but on the "Movies" tab any 4K content doesn't have the available check mark. Example.

First, "Fight Club", a 1080p movie:

image

Checkmark shows on movie cover. Next, "Wonka" a 4K movie:

image

No checkmark. Only when you click into the movie does it show "4K Available"

image

Unless I'm missing something, the behavior should show the available check mark as long as any version is available.

Hmmmm just tested this on my end and it's working fine. The title card on discover and the movies tab use the same component. Not sure what is going on from your side to be honest.

@liquid-ion
Copy link

liquid-ion commented Mar 22, 2024

Ok, sorry everyone. I'm on develop docker container version but didn't realize this has not been pushed yet.

Is there an easy way I can pull a docker container containing this update?

Majority of my content is 4K and it is very difficult to browse without the available icon.

@OwsleyJr
Copy link
Collaborator Author

I don't think this feature fully works. It does on the "Discover" tab, but on the "Movies" tab any 4K content doesn't have the available check mark. Example.
First, "Fight Club", a 1080p movie:
image
Checkmark shows on movie cover. Next, "Wonka" a 4K movie:
image
No checkmark. Only when you click into the movie does it show "4K Available"
image
Unless I'm missing something, the behavior should show the available check mark as long as any version is available.

Hmmmm just tested this on my end and it's working fine. The title card on discover and the movies tab use the same component. Not sure what is going on from your side to be honest.

It works only if there is a 1080p AND 4K version.

Can you post a screenshot where it shows the checkmark with only the 4K version available?

The checkmark for 4K only content shows only when I manually mark the movie as Available here:

image

Only then does the available checkmark show. I did the same manual update to "Oppenheimer", but before, no checkmark with only the 4K version:

image

I am 1.33.2 stable release.

I mean of course it isn't going to work. This is still a PR. It hasn't been merged yet

@liquid-ion
Copy link

liquid-ion commented Mar 25, 2024

Yes I didn't realize at the time. Apologies for that and I've edited my posts everywhere to reflect.

Thank you for adding this though, this feature would be amazing to have since the majority of my library is 4K. I get bad requests for 1080p content when the 4K exists simply because users can't easily tell that it already exists.

@Panda260
Copy link

hey any updates on this i hope this get merged!

@stale
Copy link

stale bot commented Jan 21, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 21, 2025
@stale stale bot closed this Jan 31, 2025
@OwsleyJr OwsleyJr added never-stale and removed stale labels Feb 1, 2025
@OwsleyJr OwsleyJr reopened this Feb 1, 2025
@Panda260
Copy link

Panda260 commented Feb 1, 2025

👍

@riyadchowdhury
Copy link

Hi, I would really love this feature, any updates on when it will be merged?

@fallenbagel
Copy link
Contributor

@OwsleyJr quick housekeeping. This PR predates the seerr merge and never got moved to seerr.

Want to transfer it, or should I if you don't have the time? Feels like a nice QoL win

@OwsleyJr
Copy link
Collaborator Author

@OwsleyJr quick housekeeping. This PR predates the seerr merge and never got moved to seerr.

Want to transfer it, or should I if you don't have the time? Feels like a nice QoL win

I can try when I have time but I think it needs updating as well (predates deleted status for one). Also feel free if you're feeling up to it since time is limited

@fallenbagel
Copy link
Contributor

@OwsleyJr quick housekeeping. This PR predates the seerr merge and never got moved to seerr.

Want to transfer it, or should I if you don't have the time? Feels like a nice QoL win

I can try when I have time but I think it needs updating as well (predates deleted status for one). Also feel free if you're feeling up to it since time is limited

Yeah I'm quite free these days. I'll cherry pick your commits and rebase and update

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mark media available when 4k version exists No server selection when using 4k servers

5 participants

X Tutup