{

if (erased) {

std::list<const Token*> callstack;

callstack.push_back(deref);

callstack.push_back(erased);

reportError(callstack, Severity::error, "eraseDereference",

"Iterator '" + itername + "' used after element has been erased.\n"

"The iterator '" + itername + "' is invalid after the element it pointed to has been erased. "

"Dereferencing or comparing it with another iterator is invalid operation.");

} else {

reportError(deref, Severity::error, "eraseDereference",

"Invalid iterator '" + itername + "' used.\n"

"The iterator '" + itername + "' is invalid before being assigned. "

"Dereferencing or comparing it with another iterator is invalid operation.");

}

{

const SymbolDatabase *symbolDatabase = _tokenizer->getSymbolDatabase();

// Using same iterator against different containers.

// for (it = foo.begin(); it != bar.end(); ++it)

for (unsigned int iteratorId = 1; iteratorId < symbolDatabase->getVariableListSize(); iteratorId++) {

const Variable* var = symbolDatabase->getVariableFromVarId(iteratorId);

// Check that its an iterator

if (!var || !var->isLocal() || !Token::Match(var->typeEndToken(), "iterator|const_iterator|reverse_iterator|const_reverse_iterator|auto"))

continue;

if (var->typeEndToken()->str() == "auto" && !Token::Match(var->typeEndToken(), "auto %name% ; %name% = %name% . begin|end ( )"))

continue;

if (var->type()) { // If it is defined, ensure that it is defined like an iterator

// look for operator* and operator++

const Function* end = var->type()->getFunction("operator*");

const Function* incOperator = var->type()->getFunction("operator++");

if (!end || end->argCount() > 0 || !incOperator)

continue;

}

// the validIterator flag says if the iterator has a valid value or not

bool validIterator = Token::Match(var->nameToken()->next(), "[(=]");

const Scope* invalidationScope = 0;

// The container this iterator can be used with

const Variable* container = 0;

const Scope* containerAssignScope = 0;

// When "validatingToken" is reached the validIterator is set to true

const Token* validatingToken = 0;

const Token* eraseToken = 0;

// Scan through the rest of the code and see if the iterator is

// used against other containers.

for (const Token *tok2 = var->nameToken(); tok2 && tok2 != var->scope()->classEnd; tok2 = tok2->next()) {

if (invalidationScope && tok2 == invalidationScope->classEnd)

validIterator = true; // Assume that the iterator becomes valid again

if (containerAssignScope && tok2 == containerAssignScope->classEnd)

container = 0; // We don't know which containers might be used with the iterator

if (tok2 == validatingToken)

validIterator = true;

// Is iterator compared against different container?

if (Token::Match(tok2, "%varid% !=|== %name% . end|rend|cend|crend ( )", iteratorId) && container && tok2->tokAt(2)->varId() != container->declarationId()) {

iteratorsError(tok2, container->name(), tok2->strAt(2));

tok2 = tok2->tokAt(6);

}

// Is the iterator used in a insert/erase operation?

else if (Token::Match(tok2, "%name% . insert|erase ( *| %varid% )|,", iteratorId)) {

const Token* itTok = tok2->tokAt(4);

if (itTok->str() == "*") {

if (tok2->strAt(2) == "insert")

continue;

itTok = itTok->next();

}

// It is bad to insert/erase an invalid iterator

if (!validIterator)

invalidIteratorError(tok2, itTok->str());

// If insert/erase is used on different container then

// report an error

if (container && tok2->varId() != container->declarationId()) {

// skip error message if container is a set..

const Variable *variableInfo = tok2->variable();

const Token *decltok = variableInfo ? variableInfo->typeStartToken() : nullptr;

if (Token::simpleMatch(decltok, "std :: set"))

continue; // No warning

// skip error message if the iterator is erased/inserted by value

if (itTok->previous()->str() == "*")

continue;

// Show error message, mismatching iterator is used.

iteratorsError(tok2, container->name(), tok2->str());

}

// invalidate the iterator if it is erased

else if (tok2->strAt(2) == "erase" && (tok2->strAt(4) != "*" || (container && tok2->varId() == container->declarationId()))) {

validIterator = false;

eraseToken = tok2;

invalidationScope = tok2->scope();

}

// skip the operation

tok2 = itTok->next();

}

// it = foo.erase(..

// taking the result of an erase is ok

else if (Token::Match(tok2, "%varid% = %name% .", iteratorId) &&

Token::simpleMatch(skipMembers(tok2->tokAt(2)), "erase (")) {

// the returned iterator is valid

validatingToken = tok2->linkAt(5);

tok2 = tok2->tokAt(5);

}

// Reassign the iterator

else if (Token::Match(tok2, "%varid% = %name% . begin|rbegin|cbegin|crbegin|find (", iteratorId)) {

validatingToken = tok2->linkAt(5);

container = tok2->tokAt(2)->variable();

containerAssignScope = tok2->scope();

// skip ahead

tok2 = tok2->tokAt(5);

}

// Reassign the iterator

else if (Token::Match(tok2, "%varid% = %any%", iteratorId)) {

// Assume that the iterator becomes valid.

// TODO: add checking that checks if the iterator becomes valid or not

validatingToken = Token::findmatch(tok2->tokAt(2), "[;)]");

// skip ahead

tok2 = tok2->tokAt(2);

}

// Passing iterator to function. Iterator might be initialized

else if (Token::Match(tok2, "%varid% ,|)", iteratorId)) {

validIterator = true;

}

// Dereferencing invalid iterator?

else if (!validIterator && Token::Match(tok2, "* %varid%", iteratorId)) {

dereferenceErasedError(eraseToken, tok2, tok2->strAt(1));

tok2 = tok2->next();

} else if (!validIterator && Token::Match(tok2, "%varid% . %name%", iteratorId)) {

dereferenceErasedError(eraseToken, tok2, tok2->str());

tok2 = tok2->tokAt(2);

}

// bailout handling. Assume that the iterator becomes valid if we see return/break.

// TODO: better handling

else if (Token::Match(tok2, "return|break")) {

validatingToken = Token::findsimplematch(tok2->next(), ";");

}

// bailout handling. Assume that the iterator becomes valid if we see else.

// TODO: better handling

else if (tok2 && tok2->str() == "else") {

validIterator = true;

}

}

}

{

// Check if different containers are used in various calls of standard functions

const SymbolDatabase *symbolDatabase = _tokenizer->getSymbolDatabase();

const std::size_t functions = symbolDatabase->functionScopes.size();

for (std::size_t ii = 0; ii < functions; ++ii) {

const Scope * scope = symbolDatabase->functionScopes[ii];

for (const Token* tok = scope->classStart->next(); tok != scope->classEnd; tok = tok->next()) {

if (!Token::Match(tok, "std :: %type% ( !!)"))

continue;

const Token* arg1 = tok->tokAt(4);

// TODO: If iterator variables are used instead then there are false negatives.

if (Token::Match(arg1, pattern2.c_str()) && algorithm2.find(tok->strAt(2)) != algorithm2.end()) {

if (arg1->str() != arg1->strAt(6)) {

mismatchingContainersError(arg1);

}

} else if (algorithm22.find(tok->strAt(2)) != algorithm22.end()) {

if (Token::Match(arg1, pattern2.c_str()) && arg1->str() != arg1->strAt(6))

mismatchingContainersError(arg1);

// Find third parameter

const Token* arg3 = arg1;

for (unsigned int i = 0; i < 2 && arg3; i++)

arg3 = arg3->nextArgument();

if (Token::Match(arg3, pattern2.c_str()) && arg3->str() != arg3->strAt(6))

mismatchingContainersError(arg3);

} else if (Token::Match(arg1, pattern1x1_1.c_str()) && algorithm1x1.find(tok->strAt(2)) != algorithm1x1.end()) {

// Find third parameter

const Token *arg3 = arg1->tokAt(6)->nextArgument();

if (Token::Match(arg3, pattern1x1_2.c_str())) {

if (arg1->str() != arg3->str()) {

mismatchingContainersError(arg1);

}

}

}

tok = arg1->linkAt(-1);

}

}

for (unsigned int varid = 0; varid < symbolDatabase->getVariableListSize(); varid++) {

const Variable* var = symbolDatabase->getVariableFromVarId(varid);

if (var && var->isStlStringType() && Token::Match(var->nameToken(), "%var% (") && Token::Match(var->nameToken()->tokAt(2), pattern2.c_str())) {

if (var->nameToken()->strAt(2) != var->nameToken()->strAt(8)) {

mismatchingContainersError(var->nameToken());

}

}

}

{

const SymbolDatabase* const symbolDatabase = _tokenizer->getSymbolDatabase();

// Scan through all scopes..

for (std::list<Scope>::const_iterator i = symbolDatabase->scopeList.begin(); i != symbolDatabase->scopeList.end(); ++i) {

const Token* tok = i->classDef;

// only interested in conditions

if ((i->type != Scope::eFor && i->type != Scope::eWhile && i->type != Scope::eIf && i->type != Scope::eDo) || !tok)

continue;

if (i->type == Scope::eFor)

tok = Token::findsimplematch(tok->tokAt(2), ";");

else if (i->type == Scope::eDo) {

tok = tok->linkAt(1)->tokAt(2);

} else

tok = tok->next();

if (!tok)

continue;

tok = tok->next();

// check if the for loop condition is wrong

if (Token::Match(tok, "%var% <= %var% . %name% ( ) ;|)|%oror%")) {

// Is it a vector?

const Variable *var = tok->tokAt(2)->variable();

if (!var)

continue;

const Library::Container* container = _settings->library.detectContainer(var->typeStartToken());

if (!container)

continue;

if (container->getYield(tok->strAt(4)) != Library::Container::SIZE)

continue;

// variable id for loop variable.

const unsigned int numId = tok->varId();

// variable id for the container variable

const unsigned int declarationId = var->declarationId();

for (const Token *tok3 = i->classStart; tok3 && tok3 != i->classEnd; tok3 = tok3->next()) {

if (tok3->varId() == declarationId) {

tok3 = tok3->next();

if (Token::Match(tok3, ". %name% ( )")) {

if (container->getYield(tok3->strAt(1)) == Library::Container::SIZE)

break;

} else if (container->arrayLike_indexOp && Token::Match(tok3, "[ %varid% ]", numId))

stlOutOfBoundsError(tok3, tok3->strAt(1), var->name(), false);

else if (Token::Match(tok3, ". %name% ( %varid% )", numId)) {

Library::Container::Yield yield = container->getYield(tok3->strAt(1));

if (yield == Library::Container::AT_INDEX)

stlOutOfBoundsError(tok3, tok3->strAt(3), var->name(), true);

}

}

}

continue;

}

}

{

if (at)

reportError(tok, Severity::error, "stlOutOfBounds", "When " + num + "==" + var + ".size(), " + var + ".at(" + num + ") is out of bounds.");

else

reportError(tok, Severity::error, "stlOutOfBounds", "When " + num + "==" + var + ".size(), " + var + "[" + num + "] is out of bounds.");

{

const SymbolDatabase* const symbolDatabase = _tokenizer->getSymbolDatabase();

for (std::list<Scope>::const_iterator i = symbolDatabase->scopeList.begin(); i != symbolDatabase->scopeList.end(); ++i) {

if (i->type == Scope::eFor && Token::simpleMatch(i->classDef, "for (")) {

const Token *tok = i->classDef->linkAt(1);

if (!Token::Match(tok->tokAt(-3), "; ++| %var% ++| ) {"))

continue;

tok = tok->previous();

if (!tok->isName())

tok = tok->previous();

eraseCheckLoopVar(*i, tok->variable());

} else if (i->type == Scope::eWhile && Token::Match(i->classDef, "while ( %var% !=")) {

eraseCheckLoopVar(*i, i->classDef->tokAt(2)->variable());

}

}

{

if (!var || !Token::simpleMatch(var->typeEndToken(), "iterator"))

return;

for (const Token *tok = scope.classStart; tok != scope.classEnd; tok = tok->next()) {

if (tok->str() != "(")

continue;

if (!Token::Match(tok->tokAt(-2), ". erase ( ++| %varid% )", var->declarationId()))

continue;

if (Token::simpleMatch(tok->astParent(), "="))

continue;

// Iterator is invalid..

unsigned int indentlevel = 0U;

const Token *tok2 = tok->link();

for (; tok2 != scope.classEnd; tok2 = tok2->next()) {

if (tok2->str() == "{") {

++indentlevel;

continue;

}

if (tok2->str() == "}") {

if (indentlevel > 0U)

--indentlevel;

else if (Token::simpleMatch(tok2, "} else {"))

tok2 = tok2->linkAt(2);

continue;

}

if (tok2->varId() == var->declarationId()) {

if (Token::simpleMatch(tok2->next(), "="))

break;

dereferenceErasedError(tok, tok2, tok2->str());

break;

}

if (indentlevel == 0U && Token::Match(tok2, "break|return|goto"))

break;

}

if (tok2 == scope.classEnd)

dereferenceErasedError(tok, scope.classDef, var->nameToken()->str());

}

{

// Pointer can become invalid after push_back, push_front, reserve or resize..

const SymbolDatabase* const symbolDatabase = _tokenizer->getSymbolDatabase();

const std::size_t functions = symbolDatabase->functionScopes.size();

for (std::size_t i = 0; i < functions; ++i) {

const Scope * scope = symbolDatabase->functionScopes[i];

for (const Token* tok = scope->classStart->next(); tok != scope->classEnd; tok = tok->next()) {

if (Token::Match(tok, "%var% = & %var% [")) {

// Variable id for pointer

const unsigned int pointerId(tok->varId());

// Variable id for the container variable

const unsigned int containerId(tok->tokAt(3)->varId());

bool invalidPointer = false;

const Token* function = nullptr;

const Token* end2 = tok->scope()->classEnd;

for (const Token *tok2 = tok; tok2 != end2; tok2 = tok2->next()) {

// push_back on vector..

if (Token::Match(tok2, "%varid% . push_front|push_back|insert|reserve|resize|clear", containerId)) {

invalidPointer = true;

function = tok2->tokAt(2);

}

// Using invalid pointer..

if (invalidPointer && tok2->varId() == pointerId) {

bool unknown = false;

if (CheckNullPointer::isPointerDeRef(tok2, unknown))

invalidPointerError(tok2, function->str(), tok2->str());

break;

}

}

}

}

}

// Iterator becomes invalid after reserve, resize, insert, push_back or push_front..

for (unsigned int iteratorId = 1; iteratorId < symbolDatabase->getVariableListSize(); iteratorId++) {

const Variable* var = symbolDatabase->getVariableFromVarId(iteratorId);

// Check that its an iterator

if (!var || !var->isLocal() || !Token::Match(var->typeEndToken(), "iterator|const_iterator|reverse_iterator|const_reverse_iterator"))

continue;

// ... on std::vector

if (!Token::Match(var->typeStartToken(), "std| ::| vector <"))

continue;

// the variable id for the vector

unsigned int vectorid = 0;

const Token* validatingToken = 0;

std::string invalidIterator;

const Token* end2 = var->scope()->classEnd;

for (const Token *tok2 = var->nameToken(); tok2 != end2; tok2 = tok2->next()) {

if (validatingToken == tok2) {

invalidIterator.clear();

validatingToken = 0;

}

// Using push_back or push_front inside a loop..

if (Token::simpleMatch(tok2, "for (")) {

tok2 = tok2->tokAt(2);

}

if (Token::Match(tok2, "%varid% = %var% . begin|rbegin|cbegin|crbegin ( ) ; %varid% != %var% . end|rend|cend|crend ( ) ; ++| %varid% ++| ) {", iteratorId)) {

// variable id for the loop iterator

const unsigned int varId(tok2->tokAt(2)->varId());

const Token *pushbackTok = nullptr;

// Count { and } for tok3

const Token *tok3 = tok2->tokAt(20);

for (const Token* const end3 = tok3->linkAt(-1); tok3 != end3; tok3 = tok3->next()) {

if (tok3->str() == "break" || tok3->str() == "return") {

pushbackTok = 0;

break;

} else if (Token::Match(tok3, "%varid% . push_front|push_back|insert|reserve|resize|clear|erase (", varId) && !tok3->previous()->isAssignmentOp()) {

if (tok3->strAt(2) != "erase" || (tok3->tokAt(4)->varId() != iteratorId && tok3->tokAt(5)->varId() != iteratorId)) // This case is handled in: CheckStl::iterators()

pushbackTok = tok3->tokAt(2);

}

}

if (pushbackTok)

invalidIteratorError(pushbackTok, pushbackTok->str(), tok2->str());

}

// Assigning iterator..

if (Token::Match(tok2, "%varid% =", iteratorId)) {

if (Token::Match(tok2->tokAt(2), "%var% . begin|end|rbegin|rend|cbegin|cend|crbegin|crend|insert|erase|find (")) {

if (!invalidIterator.empty() && Token::Match(tok2->tokAt(4), "insert|erase ( *| %varid% )|,", iteratorId)) {

invalidIteratorError(tok2, invalidIterator, var->name());

break;

}

vectorid = tok2->tokAt(2)->varId();

tok2 = tok2->linkAt(5);

} else {

vectorid = 0;

}

invalidIterator = "";

}

// push_back on vector..

if (vectorid > 0 && Token::Match(tok2, "%varid% . push_front|push_back|insert|reserve|resize|clear|erase (", vectorid)) {

if (!invalidIterator.empty() && Token::Match(tok2->tokAt(2), "insert|erase ( *| %varid% ,|)", iteratorId)) {

invalidIteratorError(tok2, invalidIterator, var->name());

break;

}

if (tok2->strAt(2) != "erase" || (tok2->tokAt(4)->varId() != iteratorId && tok2->tokAt(5)->varId() != iteratorId)) // This case is handled in: CheckStl::iterators()

invalidIterator = tok2->strAt(2);

tok2 = tok2->linkAt(3);

}

else if (tok2->str() == "return" || tok2->str() == "throw")

validatingToken = Token::findsimplematch(tok2->next(), ";");

// TODO: instead of bail out for 'else' try to check all execution paths.

else if (tok2->str() == "break" || tok2->str() == "else")

invalidIterator.clear();

// Using invalid iterator..

if (!invalidIterator.empty()) {

if (Token::Match(tok2, "++|--|*|+|-|(|,|=|!= %varid%", iteratorId))

invalidIteratorError(tok2, invalidIterator, tok2->strAt(1));

if (Token::Match(tok2, "%varid% ++|--|+|-|.", iteratorId))

invalidIteratorError(tok2, invalidIterator, tok2->str());

}

}

}

{

const SymbolDatabase* const symbolDatabase = _tokenizer->getSymbolDatabase();

const std::size_t functions = symbolDatabase->functionScopes.size();

for (std::size_t i = 0; i < functions; ++i) {

const Scope * scope = symbolDatabase->functionScopes[i];

for (const Token* tok = scope->classStart->next(); tok != scope->classEnd; tok = tok->next()) {

// Declaring iterator..

if (tok->str() == "<" && Token::Match(tok->previous(), "bitset|list|forward_list|map|multimap|multiset|priority_queue|queue|set|stack|hash_map|hash_multimap|hash_set|unordered_map|unordered_multimap|unordered_set|unordered_multiset")) {

if (!tok->link())

continue;

const std::string& container_name(tok->strAt(-1));

tok = tok->link();

if (Token::Match(tok, "> :: iterator|const_iterator %var% =|;")) {

const unsigned int iteratorid(tok->tokAt(3)->varId());

// Using "iterator < ..." is not allowed

const Token* const end = tok->scope()->classEnd;

for (const Token *tok2 = tok; tok2 != end; tok2 = tok2->next()) {

if (Token::Match(tok2, "!!* %varid% <", iteratorid)) {

stlBoundariesError(tok2, container_name);

} else if (Token::Match(tok2, "> %varid% !!.", iteratorid)) {

stlBoundariesError(tok2, container_name);

}

}

}

}

}

}

{

reportError(tok, Severity::error, "stlBoundaries",

"Dangerous iterator comparison using operator< on 'std::" + container_name + "'.\n"

"Iterator of container 'std::" + container_name + "' compared with operator<. "

"This is dangerous since the order of items in the container is not guaranteed. "

"One should use operator!= instead to compare iterators.");

{

const Token *tok = tokBack->astParent();

if (!tok)

return true;

if (tok->isComparisonOp())

return (!tok->astOperand1()->isNumber() && !tok->astOperand2()->isNumber());

if (tok->isArithmeticalOp()) // result is used in some calculation

return true; // TODO: check if there is a comparison of the result somewhere

if (tok->str() == ".")

return true; // Dereferencing is OK, the programmer might know that the element exists - TODO: An inconclusive warning might be appropriate

if (tok->isAssignmentOp())

return if_findCompare(tok); // Go one step upwards in the AST

return false;

{

const bool printWarning = _settings->isEnabled("warning");

const bool printPerformance = _settings->isEnabled("performance");

if (!printWarning && !printPerformance)

return;

const SymbolDatabase *symbolDatabase = _tokenizer->getSymbolDatabase();

for (std::list<Scope>::const_iterator i = symbolDatabase->scopeList.begin(); i != symbolDatabase->scopeList.end(); ++i) {

if ((i->type != Scope::eIf && i->type != Scope::eWhile) || !i->classDef)

continue;

for (const Token *tok = i->classDef; tok->str() != "{"; tok = tok->next()) {

const Token* funcTok = nullptr;

const Library::Container* container = nullptr;

if (tok->variable() && Token::Match(tok, "%var% . %name% (")) {

container = _settings->library.detectContainer(tok->variable()->typeStartToken());

funcTok = tok->tokAt(2);

}

// check also for vector-like or pointer containers

else if (tok->variable() && tok->astParent() && (tok->astParent()->str() == "*" || tok->astParent()->str() == "[")) {

const Token *tok2 = tok->astParent();

if (!Token::Match(tok2->astParent(), ". %name% ("))

continue;

funcTok = tok2->astParent()->next();

if (tok->variable()->isArrayOrPointer())

container = _settings->library.detectContainer(tok->variable()->typeStartToken());

else { // Container of container - find the inner container

container = _settings->library.detectContainer(tok->variable()->typeStartToken()); // outer container

tok2 = Token::findsimplematch(tok->variable()->typeStartToken(), "<", tok->variable()->typeEndToken());

if (container && container->type_templateArgNo >= 0 && tok2) {

tok2 = tok2->next();

for (int j = 0; j < container->type_templateArgNo; j++)

tok2 = tok2->nextTemplateArgument();

container = _settings->library.detectContainer(tok2); // innner container

} else

container = nullptr;

}

}

if (container && container->getAction(funcTok->str()) == Library::Container::FIND) {

if (if_findCompare(funcTok->next()))

continue;

if (printWarning && !container->stdStringLike)

if_findError(tok, false);

else if (printPerformance && container->stdStringLike)

if_findError(tok, true);

} else if (printWarning && Token::Match(tok, "std :: find|find_if (")) {

// check that result is checked properly

if (!if_findCompare(tok->tokAt(3))) {

if_findError(tok, false);

}

}

}

}

{

if (str)

reportError(tok, Severity::performance, "stlIfStrFind",

"Inefficient usage of string::find() in condition; string::compare() would be faster.\n"

"Either inefficient or wrong usage of string::find(). string::compare() will be faster if "

"string::find's result is compared with 0, because it will not scan the whole "

"string. If your intention is to check that there are no findings in the string, "

"you should compare with std::string::npos.");

else

reportError(tok, Severity::warning, "stlIfFind", "Suspicious condition. The result of find() is an iterator, but it is not properly checked.");

{

if (!tok)

return false;

const Variable* var = tok->variable();

return var && var->isStlType("list");

{

if (!_settings->isEnabled("performance"))

return;

if (_settings->standards.cpp == Standards::CPP11)

return;

const SymbolDatabase* const symbolDatabase = _tokenizer->getSymbolDatabase();

const std::size_t functions = symbolDatabase->functionScopes.size();

for (std::size_t i = 0; i < functions; ++i) {

const Scope * scope = symbolDatabase->functionScopes[i];

for (const Token* tok = scope->classStart->next(); tok != scope->classEnd; tok = tok->next()) {

if (Token::Match(tok, "%var% . size ( )") ||

Token::Match(tok, "%name% . %var% . size ( )")) {

// get the variable

const Token *varTok = tok;

if (tok->strAt(2) != "size")

varTok = varTok->tokAt(2);

const Token* const end = varTok->tokAt(5);

// check for comparison to zero

if ((tok->previous() && !tok->previous()->isArithmeticalOp() && Token::Match(end, "==|<=|!=|> 0")) ||

(end->next() && !end->next()->isArithmeticalOp() && Token::Match(tok->tokAt(-2), "0 ==|>=|!=|<"))) {

if (isCpp03ContainerSizeSlow(varTok)) {

sizeError(varTok);

continue;

}

}

// check for comparison to one

if ((tok->previous() && !tok->previous()->isArithmeticalOp() && Token::Match(end, ">=|< 1") && !end->tokAt(2)->isArithmeticalOp()) ||

(end->next() && !end->next()->isArithmeticalOp() && Token::Match(tok->tokAt(-2), "1 <=|>") && !tok->tokAt(-3)->isArithmeticalOp())) {

if (isCpp03ContainerSizeSlow(varTok))

sizeError(varTok);

}

// check for using as boolean expression

else if ((Token::Match(tok->tokAt(-2), "if|while (") && end->str() == ")") ||

(tok->previous()->tokType() == Token::eLogicalOp && Token::Match(end, "&&|)|,|;|%oror%"))) {

if (isCpp03ContainerSizeSlow(varTok))

sizeError(varTok);

}

}

}

}

{

const std::string varname = tok ? tok->str() : std::string("list");

reportError(tok, Severity::performance, "stlSize",

"Possible inefficient checking for '" + varname + "' emptiness.\n"

"Checking for '" + varname + "' emptiness might be inefficient. "

"Using " + varname + ".empty() instead of " + varname + ".size() can be faster. " +

varname + ".size() can take linear time but " + varname + ".empty() is "

"guaranteed to take constant time.");

{

if (!_settings->isEnabled("style"))

return;

const SymbolDatabase *symbolDatabase = _tokenizer->getSymbolDatabase();

for (std::list<Scope>::const_iterator i = symbolDatabase->scopeList.begin(); i != symbolDatabase->scopeList.end(); ++i) {

if (i->type != Scope::eIf)

continue;

const Token* tok = i->classDef->tokAt(2);

if (!Token::Match(tok, "%name% . find ( %any% ) != %name% . end|rend|cend|crend ( ) ) { %name% . remove|erase ( %any% ) ;"))

continue;

// Get tokens for the fields %name% and %any%

const Token *var1 = tok;

const Token *any1 = var1->tokAt(4);

const Token *var2 = any1->tokAt(3);

const Token *var3 = var2->tokAt(7);

const Token *any2 = var3->tokAt(4);

// Check if all the "%name%" fields are the same and if all the "%any%" are the same..

if (var1->str() == var2->str() &&

var2->str() == var3->str() &&

any1->str() == any2->str()) {

redundantIfRemoveError(tok);

}

}

{

reportError(tok, Severity::style, "redundantIfRemove",

"Redundant checking of STL container element existence before removing it.\n"

"Redundant checking of STL container element existence before removing it. "

"It is safe to call the remove method on a non-existing element.");

{

if (!_settings->isEnabled("warning"))

return;

const SymbolDatabase* const symbolDatabase = _tokenizer->getSymbolDatabase();

for (std::list<Scope>::const_iterator i = symbolDatabase->scopeList.begin(); i != symbolDatabase->scopeList.end(); ++i) {

if (i->type != Scope::eFor || !i->classDef)

continue;

for (const Token *tok2 = i->classDef->tokAt(2); tok2 != i->classStart; tok2 = tok2->next()) {

if (tok2->str() == ";")

break;

if (!Token::Match(tok2, "%var% = %name% . begin|rbegin|cbegin|crbegin ( ) ; %name% != %name% . end|rend|cend|crend ( ) ; ++| %name% ++| ) {"))

continue;

// same container

if (tok2->strAt(2) != tok2->strAt(10))

break;

const unsigned int iteratorId(tok2->varId());

// same iterator

if (iteratorId == tok2->tokAt(10)->varId())

break;

// increment iterator

if (!Token::Match(tok2->tokAt(16), "++ %varid% )", iteratorId) &&

!Token::Match(tok2->tokAt(16), "%varid% ++ )", iteratorId)) {

break;

}

const Token *incrementToken = nullptr;

// Parse loop..

for (const Token *tok3 = i->classStart; tok3 != i->classEnd; tok3 = tok3->next()) {

if (Token::Match(tok3, "%varid% ++", iteratorId))

incrementToken = tok3;

else if (Token::Match(tok3->previous(), "++ %varid% !!.", iteratorId))

incrementToken = tok3;

else if (Token::Match(tok3, "%varid% !=|==", iteratorId))

incrementToken = 0;

else if (tok3->str() == "break" || tok3->str() == "return")

incrementToken = 0;

else if (Token::Match(tok3, "%varid% = %name% . insert ( ++| %varid% ++| ,", iteratorId)) {

// skip insertion..

tok3 = tok3->linkAt(6);

if (!tok3)

break;

}

}

if (incrementToken)

missingComparisonError(incrementToken, tok2->tokAt(16));

}

}

{

std::list<const Token*> callstack;

callstack.push_back(incrementToken1);

callstack.push_back(incrementToken2);

std::ostringstream errmsg;

errmsg << "Missing bounds check for extra iterator increment in loop.\n"

<< "The iterator incrementing is suspicious - it is incremented at line ";

if (incrementToken1)

errmsg << incrementToken1->linenr();

errmsg << " and then at line ";

if (incrementToken2)

errmsg << incrementToken2->linenr();

errmsg << ". The loop might unintentionally skip an element in the container. "

<< "There is no comparison between these increments to prevent that the iterator is "

<< "incremented beyond the end.";

reportError(callstack, Severity::warning, "StlMissingComparison", errmsg.str());

{

const Variable *var = tok->variable();

return var && !var->isStatic() && var->isLocal();

{

const bool printInconclusive = _settings->inconclusive;

const bool printPerformance = _settings->isEnabled("performance");

const SymbolDatabase* symbolDatabase = _tokenizer->getSymbolDatabase();

// Find all functions that take std::string as argument

std::multimap<std::string, unsigned int> c_strFuncParam;

if (printPerformance) {

for (std::list<Scope>::const_iterator scope = symbolDatabase->scopeList.begin(); scope != symbolDatabase->scopeList.end(); ++scope) {

for (std::list<Function>::const_iterator func = scope->functionList.begin(); func != scope->functionList.end(); ++func) {

if (c_strFuncParam.erase(func->tokenDef->str()) != 0) { // Check if function with this name was already found

c_strFuncParam.insert(std::make_pair(func->tokenDef->str(), 0)); // Disable, because there are overloads. TODO: Handle overloads

continue;

}

unsigned int numpar = 0;

c_strFuncParam.insert(std::make_pair(func->tokenDef->str(), numpar)); // Insert function as dummy, to indicate that there is at least one function with that name

for (const Token* tok = func->argDef->next(); tok != 0; tok = tok->nextArgument()) {

numpar++;

if (Token::Match(tok, "std :: string|wstring !!&") || Token::Match(tok, "const std :: string|wstring"))

c_strFuncParam.insert(std::make_pair(func->tokenDef->str(), numpar));

}

}

}

}

// Try to detect common problems when using string::c_str()

for (std::list<Scope>::const_iterator scope = symbolDatabase->scopeList.begin(); scope != symbolDatabase->scopeList.end(); ++scope) {

if (scope->type != Scope::eFunction || !scope->function)

continue;

enum {charPtr, stdString, stdStringConstRef, Other} returnType = Other;

if (Token::Match(scope->function->tokenDef->tokAt(-2), "char|wchar_t *"))

returnType = charPtr;

else if (Token::Match(scope->function->tokenDef->tokAt(-5), "const std :: string|wstring &"))

returnType = stdStringConstRef;

else if (Token::Match(scope->function->tokenDef->tokAt(-3), "std :: string|wstring !!&"))

returnType = stdString;

for (const Token *tok = scope->classStart; tok && tok != scope->classEnd; tok = tok->next()) {

// Invalid usage..

if (Token::Match(tok, "throw %var% . c_str|data ( ) ;") && isLocal(tok->next()) &&

tok->next()->variable() && tok->next()->variable()->isStlType(stl_string)) {

string_c_strThrowError(tok);

} else if (Token::Match(tok, "[;{}] %name% = %var% . str ( ) . c_str|data ( ) ;")) {

const Variable* var = tok->next()->variable();

const Variable* var2 = tok->tokAt(3)->variable();

if (var && var->isPointer() && var2 && var2->isStlType(stl_string_stream))

string_c_strError(tok);

} else if (Token::Match(tok, "[;{}] %var% = %name% (") &&

Token::Match(tok->linkAt(4), ") . c_str|data ( ) ;") &&

tok->tokAt(3)->function() && Token::Match(tok->tokAt(3)->function()->retDef, "std :: string|wstring %name%")) {

const Variable* var = tok->next()->variable();

if (var && var->isPointer())

string_c_strError(tok);

} else if (printPerformance && Token::Match(tok, "%name% ( !!)") && c_strFuncParam.find(tok->str()) != c_strFuncParam.end() &&

!Token::Match(tok->previous(), "::|.") && tok->varId() == 0 && tok->str() != scope->className) { // calling function. TODO: Add support for member functions

std::pair<std::multimap<std::string, unsigned int>::const_iterator, std::multimap<std::string, unsigned int>::const_iterator> range = c_strFuncParam.equal_range(tok->str());

for (std::multimap<std::string, unsigned int>::const_iterator i = range.first; i != range.second; ++i) {

if (i->second == 0)

continue;

const Token* tok2 = tok->tokAt(2);

unsigned int j;

for (j = 0; tok2 && j < i->second-1; j++)

tok2 = tok2->nextArgument();

if (tok2)

tok2 = tok2->nextArgument();

else

break;

if (!tok2 && j == i->second-1)

tok2 = tok->next()->link();

else

tok2 = tok2->previous();