Closed
Conversation
… This is the first try for comment.
This will prevent failure for non standard port and uppercase host or scheme strings Added related test cases. Warning : Request constructor signature changed. A java.net.MalformedURLException exception will be throw when creating a request if not a proper URL previously this cannot occur until send.
Author
|
Oups sorry this is related to https://github.com/fernandezpablo85/scribe-java/issues/#issue/56 I'm not familiar with GIT yet ;-) |
Collaborator
|
Ok I've merged this in my local master branch. I'll run some tests, split those 2 (big to my taste) commits in smaller ones and try to wrap up for a new upcoming release. Thanks a lot again krogoth |
Collaborator
|
We can't use this last patch since it would prevent android-like URLs (that don't start with http or https) |
Author
|
So would you include Patch 1? |
Collaborator
|
Yes dude :) I've already included the patch, split it into smaller commits that are easier to handle though. You will be properly credited in the changelist |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pach fix bad encoding of Base string URI:
-Handdling hash probably not detected
-Processing lowercase on scheme and host (RFC5849 c3.4.1.2 p20)
-Properly removing only port if standard http or https.
Unfortunatly it changes the Request constructor that is now throwing MalformedUrl exception if the URL provided is not a proper URL. If this is not the behaviour you want, it's easy to change.